Skip to content

Commit d5674fd

Browse files
RamanandPatilgireeshpunathil
authored andcommitted
src: elevate v8 namespace
PR-URL: #32041 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent c1b2f6a commit d5674fd

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/cares_wrap.cc

+3-2
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,7 @@ using v8::FunctionTemplate;
6464
using v8::HandleScope;
6565
using v8::Int32;
6666
using v8::Integer;
67+
using v8::Isolate;
6768
using v8::Local;
6869
using v8::Null;
6970
using v8::Object;
@@ -1917,7 +1918,7 @@ int ParseIP(const char* ip, ParseIPResult* result = nullptr) {
19171918
}
19181919

19191920
void CanonicalizeIP(const FunctionCallbackInfo<Value>& args) {
1920-
v8::Isolate* isolate = args.GetIsolate();
1921+
Isolate* isolate = args.GetIsolate();
19211922
node::Utf8Value ip(isolate, args[0]);
19221923

19231924
ParseIPResult result;
@@ -1927,7 +1928,7 @@ void CanonicalizeIP(const FunctionCallbackInfo<Value>& args) {
19271928
char canonical_ip[INET6_ADDRSTRLEN];
19281929
const int af = (rc == 4 ? AF_INET : AF_INET6);
19291930
CHECK_EQ(0, uv_inet_ntop(af, &result, canonical_ip, sizeof(canonical_ip)));
1930-
v8::Local<String> val = String::NewFromUtf8(isolate, canonical_ip,
1931+
Local<String> val = String::NewFromUtf8(isolate, canonical_ip,
19311932
v8::NewStringType::kNormal).ToLocalChecked();
19321933
args.GetReturnValue().Set(val);
19331934
}

0 commit comments

Comments
 (0)