Skip to content

Commit d663470

Browse files
richardlautargos
authored andcommitted
build: run V8 tests with detected Python version
V8's test runner now requires Python 3. Use the Python binary we detected that is used elsewhere in the Makefile. PR-URL: #42740 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
1 parent 5228028 commit d663470

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Makefile

+3-3
Original file line numberDiff line numberDiff line change
@@ -679,21 +679,21 @@ ifneq ("","$(wildcard deps/v8/tools/run-tests.py)")
679679
# Related CI job: node-test-commit-v8-linux
680680
test-v8: v8 ## Runs the V8 test suite on deps/v8.
681681
export PATH="$(NO_BIN_OVERRIDE_PATH)" && \
682-
deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) $(V8_TEST_OPTIONS) \
682+
$(PYTHON) deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) $(V8_TEST_OPTIONS) \
683683
mjsunit cctest debugger inspector message preparser \
684684
$(TAP_V8)
685685
$(info Testing hash seed)
686686
$(MAKE) test-hash-seed
687687

688688
test-v8-intl: v8
689689
export PATH="$(NO_BIN_OVERRIDE_PATH)" && \
690-
deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) \
690+
$(PYTHON) deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) \
691691
intl \
692692
$(TAP_V8_INTL)
693693

694694
test-v8-benchmarks: v8
695695
export PATH="$(NO_BIN_OVERRIDE_PATH)" && \
696-
deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) \
696+
$(PYTHON) deps/v8/tools/run-tests.py --gn --arch=$(V8_ARCH) \
697697
benchmarks \
698698
$(TAP_V8_BENCHMARKS)
699699

0 commit comments

Comments
 (0)