Skip to content

Commit d77a1b0

Browse files
bnoordhuiscodebytere
authored andcommitted
src: remove node::InitializeV8Platform()
This API method was introduced in commit 90ae4bd ("src: add InitializeV8Platform function") from July 2018 but wasn't properly exported and therefore not usable on Windows or with shared library builds. The motivation from the commit log is mainly about making it easier to wire up the cctests and there are better ways to do that. Refs: #31217 PR-URL: #31245 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent fe1ac49 commit d77a1b0

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

src/api/environment.cc

-5
Original file line numberDiff line numberDiff line change
@@ -352,11 +352,6 @@ MultiIsolatePlatform* CreatePlatform(
352352
return new NodePlatform(thread_pool_size, tracing_controller);
353353
}
354354

355-
MultiIsolatePlatform* InitializeV8Platform(int thread_pool_size) {
356-
per_process::v8_platform.Initialize(thread_pool_size);
357-
return per_process::v8_platform.Platform();
358-
}
359-
360355
void FreePlatform(MultiIsolatePlatform* platform) {
361356
delete platform;
362357
}

src/node.h

-1
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,6 @@ NODE_EXTERN MultiIsolatePlatform* GetMainThreadMultiIsolatePlatform();
379379
NODE_EXTERN MultiIsolatePlatform* CreatePlatform(
380380
int thread_pool_size,
381381
node::tracing::TracingController* tracing_controller);
382-
MultiIsolatePlatform* InitializeV8Platform(int thread_pool_size);
383382
NODE_EXTERN void FreePlatform(MultiIsolatePlatform* platform);
384383

385384
NODE_EXTERN void EmitBeforeExit(Environment* env);

0 commit comments

Comments
 (0)