You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I should have done this a few days ago so it could land in time for Code
& Learn, but oh well. Here are some revisions to BUILDING.md to try to
make it easier to read.
PR-URL: #23435
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Copy file name to clipboardexpand all lines: BUILDING.md
+11-16
Original file line number
Diff line number
Diff line change
@@ -52,8 +52,7 @@ which it is attached.
52
52
53
53
### Input
54
54
55
-
Node.js relies on V8 and libuv. Therefore, we adopt a subset of their
56
-
supported platforms.
55
+
Node.js relies on V8 and libuv. We adopt a subset of their supported platforms.
57
56
58
57
### Strategy
59
58
@@ -111,8 +110,8 @@ platforms in production.
111
110
community will only address issues that reproduce on native GNU/Linux
112
111
systems. Issues that only reproduce on WSL should be reported in the
113
112
[WSL issue tracker](https://github.com/Microsoft/WSL/issues). Running the
114
-
Windows binary (`node.exe`) in WSL is not recommended, and will not work
115
-
without adjustment (such as stdio redirection).
113
+
Windows binary (`node.exe`) in WSL is not recommended. It will not work
114
+
without workarounds such as stdio redirection.
116
115
117
116
### Supported toolchains
118
117
@@ -144,10 +143,8 @@ Otherwise `configure` will fail with an error. This can be avoided by
144
143
either providing a newer assembler as per the list above or by
145
144
using the `--openssl-no-asm` flag.
146
145
147
-
*Note:* The forthcoming OpenSSL-1.1.1 will require higher
148
-
version. Please refer
149
-
https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_ia32cap.html for
150
-
details.
146
+
The forthcoming OpenSSL-1.1.1 will have different requirements. Please refer to
147
+
https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_ia32cap.html for details.
151
148
152
149
## Building Node.js on supported platforms
153
150
@@ -216,7 +213,7 @@ $ make test-only
216
213
217
214
At this point, you are ready to make code changes and re-run the tests.
218
215
219
-
If you are running tests prior to submitting a Pull Request, the recommended
216
+
If you are running tests before submitting a Pull Request, the recommended
220
217
command is:
221
218
222
219
```console
@@ -344,7 +341,7 @@ Prerequisites:
344
341
and tools which can be included in the global `PATH`.
345
342
* The [NetWide Assembler](http://www.nasm.us/), for OpenSSL assembler modules.
346
343
If not installed in the default location, it needs to be manually added
347
-
to `PATH`. Build with `openssl-no-asm` option does not require this.
344
+
to `PATH`. A build with the `openssl-no-asm` option does not need this.
348
345
***Optional** (to build the MSI): the [WiX Toolset v3.11](http://wixtoolset.org/releases/)
349
346
and the [Wix Toolset Visual Studio 2017 Extension](https://marketplace.visualstudio.com/items?itemName=RobMensching.WixToolsetVisualStudio2017Extension).
350
347
@@ -369,12 +366,10 @@ To test if Node.js was built correctly:
0 commit comments