Skip to content

Commit d968520

Browse files
Trottjasnell
authored andcommitted
doc: recommend node-core-utils for metadata
PR-URL: #16978 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 29de91b commit d968520

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

COLLABORATOR_GUIDE.md

+2-3
Original file line numberDiff line numberDiff line change
@@ -501,8 +501,7 @@ commit logs, ensure that they are properly formatted, and add
501501

502502
<a name="metadata"></a>
503503
* Modify the original commit message to include additional metadata regarding
504-
the change process. (If you use Chrome or Edge, [`node-review`][] fetches
505-
the metadata for you.)
504+
the change process. ([`node-core-utils`][] fetches the metadata for you.)
506505

507506
* Required: A `PR-URL:` line that references the *full* GitHub URL of the
508507
original pull request being merged so it's easy to trace a commit back to
@@ -681,4 +680,4 @@ LTS working group and the Release team.
681680
[Stability Index]: doc/api/documentation.md#stability-index
682681
[Enhancement Proposal]: https://github.com/nodejs/node-eps
683682
[git-username]: https://help.github.com/articles/setting-your-username-in-git/
684-
[`node-review`]: https://github.com/evanlucas/node-review
683+
[`node-core-utils`]: https://github.com/nodejs/node-core-utils

doc/onboarding.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ onboarding session.
158158
* After one or two approvals, land the PR.
159159
* Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:` metadata!
160160
* [`core-validate-commit`][] helps a lot with this – install and use it if you can!
161-
* If you use Chrome or Edge, [`node-review`][] fetches the metadata for you.
161+
* [`node-core-utils`][] fetches the metadata for you.
162162

163163
## Final notes
164164

@@ -180,4 +180,4 @@ onboarding session.
180180

181181
[Code of Conduct]: https://github.com/nodejs/TSC/blob/master/CODE_OF_CONDUCT.md
182182
[`core-validate-commit`]: https://github.com/evanlucas/core-validate-commit
183-
[`node-review`]: https://github.com/evanlucas/node-review
183+
[`node-core-utils`]: https://github.com/nodejs/node-core-utils

0 commit comments

Comments
 (0)