Skip to content

Commit dbd0608

Browse files
mcollinaBethGriggs
authored andcommitted
readline: make Symbol.asyncIterator support stable
PR-URL: #26989 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
1 parent b29afa2 commit dbd0608

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

doc/api/readline.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -312,9 +312,13 @@ The `rl.write()` method will write the data to the `readline` `Interface`'s
312312
### rl\[Symbol.asyncIterator\]()
313313
<!-- YAML
314314
added: v11.4.0
315+
changes:
316+
- version: REPLACEME
317+
pr-url: https://github.com/nodejs/node/pull/26989
318+
description: Symbol.asyncIterator support is no longer experimental.
315319
-->
316320

317-
> Stability: 1 - Experimental
321+
> Stability: 2 - Stable
318322
319323
* Returns: {AsyncIterator}
320324

lib/readline.js

-3
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ const {
3333
} = require('internal/errors').codes;
3434
const { inspect, inherits } = require('util');
3535
const { validateString } = require('internal/validators');
36-
const { emitExperimentalWarning } = require('internal/util');
3736
const { Buffer } = require('buffer');
3837
const EventEmitter = require('events');
3938
const {
@@ -1030,8 +1029,6 @@ Interface.prototype._ttyWrite = function(s, key) {
10301029
};
10311030

10321031
Interface.prototype[Symbol.asyncIterator] = function() {
1033-
emitExperimentalWarning('readline Interface [Symbol.asyncIterator]');
1034-
10351032
if (this[kLineObjectStream] === undefined) {
10361033
if (Readable === undefined) {
10371034
Readable = require('stream').Readable;

0 commit comments

Comments
 (0)