used more primordials

Author: pulkit-30

lib/internal/test_runner/reporter/tap.js

@@ -1,21 +1,23 @@
 'use strict';
 const {
+  ArrayPrototypeFilter,
   ArrayPrototypeForEach,
   ArrayPrototypeJoin,
   ArrayPrototypePush,
+  ArrayPrototypeSlice,
   NumberPrototypeToFixed,
   ObjectEntries,
   RegExpPrototypeSymbolReplace,
   SafeMap,
+  StringPrototypeRepeat,
   StringPrototypeReplaceAll,
   StringPrototypeSplit,
-  StringPrototypeRepeat,
   StringPrototypeStartsWith
 } = primordials;
 const { inspectWithNoCustomRetry } = require('internal/errors');
 const { isError, kEmptyObject } = require('internal/util');
 const { relative } = require('path');
-const util = require('util');
+const { inspect } = require('internal/util/inspect');
 const kDefaultIndent = '    '; // 4 spaces
 const kFrameStartRegExp = /^ {4}at /;
 const kLineBreakRegExp = /\n|\r\n/;
@@ -239,9 +241,9 @@ function jsToYaml(indent, name, value) {
     const frames = [];
 
     if (cause?.cause) {
-      const errCause = util.inspect(cause).split('\n').slice(1)
-                      .filter((line) => !StringPrototypeStartsWith(line.trim(), '...') && line)
-                      .join('\n');
+      const errCause = ArrayPrototypeJoin(
+        ArrayPrototypeFilter(ArrayPrototypeSlice(StringPrototypeSplit(inspect(cause), '\n'), 1), (line) =>
+          line && typeof line === 'string' && !StringPrototypeStartsWith(line.trim(), '...')), '\n');
       ArrayPrototypeForEach(
         StringPrototypeSplit(errCause, kLineBreakRegExp),
         (frame) => {

test/message/test_runner_output.js

@@ -385,14 +385,16 @@ test('unfinished test with unhandledRejection', async () => {
 });
 
 test('should print error cause', () => {
-  throw new Error('foo', {cause: new Error('bar')});
+  Error.stackTraceLimit = 4;
+  throw new Error('foo', { cause: new Error('bar') });
 });
 
 test('should print error cause for nested errors', () => {
-  throw new Error('a', { cause: new Error('b', { cause: new Error('c', { cause: new Error('d', { cause: new Error('e') }) }) }) })
+  throw new Error('a', { cause: new Error('b', { cause:
+    new Error('c', { cause: new Error('d', { cause: new Error('e') }) }) }) });
 });
 
-test("should handle cycles in error", () => {
+test('should handle cycles in error', () => {
   const outer = new Error('b', { cause: null });
   outer.cause = new Error('c', { cause: new Error('d', { cause: outer }) });
   throw outer;

test/message/test_runner_output.out

@@ -642,9 +642,6 @@ not ok 65 - should print error cause
     *
     *
     *
-    *
-    *
-    *
   ...
 # Subtest: should print error cause for nested errors
 not ok 66 - should print error cause for nested errors
@@ -669,6 +666,9 @@ not ok 66 - should print error cause for nested errors
     *
     *
     *
+    *
+    *
+    *
   ...
 # Subtest: should handle cycles in error
 not ok 67 - should handle cycles in error
@@ -693,6 +693,9 @@ not ok 67 - should handle cycles in error
     *
     *
     *
+    *
+    *
+    *
   ...
 # Subtest: invalid subtest fail
 not ok 68 - invalid subtest fail

test/message/test_runner_output_cli.out

@@ -643,9 +643,6 @@ TAP version 13
         *
         *
         *
-        *
-        *
-        *
       ...
     # Subtest: should print error cause for nested errors
     not ok 66 - should print error cause for nested errors
@@ -670,6 +667,9 @@ TAP version 13
         *
         *
         *
+        *
+        *
+        *
       ...
     # Subtest: should handle cycles in error
     not ok 67 - should handle cycles in error
@@ -679,21 +679,24 @@ TAP version 13
       error: 'b'
       code: 'ERR_TEST_FAILURE'
       stack: |-
-       *
-       *
-       *
-       *
-       *
-       *
-       *
-       *
-       *
-       *
-       *
-       *
-       *
-       *
-       *
+        *
+        *
+        *
+        *
+        *
+        *
+        *
+        *
+        *
+        *
+        *
+        *
+        *
+        *
+        *
+        *
+        *
+        *
       ...
     # Subtest: invalid subtest fail
     not ok 68 - invalid subtest fail

test/message/test_runner_output_spec_reporter.out

@@ -274,10 +274,6 @@
   *
   *
   *
-  *
-  *
-  *
-  *
 
  should print error cause for nested errors (*ms)
   Error: a