Skip to content

Commit de82db7

Browse files
gr2mMylesBorins
authored andcommitted
build: ignore empty folders in test-addons
Fixes: #14843 PR-URL: #16031 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent c35420d commit de82db7

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

Makefile

+3
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,10 @@ test/addons/.buildstamp: config.gypi \
168168
test/addons/.docbuildstamp
169169
# Cannot use $(wildcard test/addons/*/) here, it's evaluated before
170170
# embedded addons have been generated from the documentation.
171+
# Ignore folders without binding.gyp (#14843)
171172
@for dirname in test/addons/*/; do \
173+
if [ ! -f "$$PWD/$${dirname}binding.gyp" ]; then \
174+
continue; fi ; \
172175
printf "\nBuilding addon $$PWD/$$dirname\n" ; \
173176
env MAKEFLAGS="-j1" $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp \
174177
--loglevel=$(LOGLEVEL) rebuild \

0 commit comments

Comments
 (0)