Skip to content

Commit e27f432

Browse files
starkwangtargos
authored andcommitted
repl: use promise#finally
PR-URL: #23971 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent c7f471a commit e27f432

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

lib/repl.js

+4-10
Original file line numberDiff line numberDiff line change
@@ -376,25 +376,19 @@ function REPLServer(prompt,
376376
}
377377

378378
promise.then((result) => {
379-
// Remove prioritized SIGINT listener if it was not called.
380-
// TODO(TimothyGu): Use Promise.prototype.finally when it becomes
381-
// available.
382-
prioritizedSigintQueue.delete(sigintListener);
383-
384379
finishExecution(undefined, result);
385-
unpause();
386380
}, (err) => {
387-
// Remove prioritized SIGINT listener if it was not called.
388-
prioritizedSigintQueue.delete(sigintListener);
389-
390-
unpause();
391381
if (err && process.domain) {
392382
debug('not recoverable, send to domain');
393383
process.domain.emit('error', err);
394384
process.domain.exit();
395385
return;
396386
}
397387
finishExecution(err);
388+
}).finally(() => {
389+
// Remove prioritized SIGINT listener if it was not called.
390+
prioritizedSigintQueue.delete(sigintListener);
391+
unpause();
398392
});
399393
}
400394
}

0 commit comments

Comments
 (0)