Skip to content

Commit e446d82

Browse files
psmarshallMylesBorins
authored andcommitted
deps: V8: cherry-pick beebee4f80ff
Original commit message: ``` cpu-profiler: Use Handle version of SourcePositionTableIterator The surrounding code can trigger an allocation through InliningStack which can eventually end up allocating a line ends array. This is fine as-is because the existing iterator code makes a copy of the byte array. It just triggers the no_gc dcheck in debug mode. Fixed: v8:10778 Change-Id: Ic8c502767ec6c3d3b1f5e84df60638bd2fc6be75 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2339102 Auto-Submit: Peter Marshall <petermarshall@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#69247} ``` Refs: v8/v8@beebee4 PR-URL: #37293 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
1 parent 6961be5 commit e446d82

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.18',
39+
'v8_embedder_string': '-node.19',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/profiler/profiler-listener.cc

+2-1
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,8 @@ void ProfilerListener::CodeCreateEvent(LogEventsAndTags tag,
113113
// profiler as is stored on the code object, except that we transform source
114114
// positions to line numbers here, because we only care about attributing
115115
// ticks to a given line.
116-
for (SourcePositionTableIterator it(abstract_code->source_position_table());
116+
for (SourcePositionTableIterator it(
117+
handle(abstract_code->source_position_table(), isolate_));
117118
!it.done(); it.Advance()) {
118119
int position = it.source_position().ScriptOffset();
119120
int inlining_id = it.source_position().InliningId();

0 commit comments

Comments
 (0)