Skip to content

Commit e5f6159

Browse files
joyeecheungevanlucas
authored andcommitted
doc: document the collaborator nomination process
PR-URL: #18268 Fixes: #18090 Refs: nodejs/TSC#472 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
1 parent c9e09ad commit e5f6159

File tree

2 files changed

+93
-25
lines changed

2 files changed

+93
-25
lines changed

GOVERNANCE.md

+91-25
Original file line numberDiff line numberDiff line change
@@ -4,27 +4,30 @@ The Node.js project is governed by its Collaborators, including a Technical
44
Steering Committee (TSC) which is responsible for high-level guidance of the
55
project.
66

7+
<!-- TOC -->
8+
9+
- [Collaborators](#collaborators)
10+
- [Collaborator Activities](#collaborator-activities)
11+
- [Technical Steering Committee](#technical-steering-committee)
12+
- [TSC Meetings](#tsc-meetings)
13+
- [Collaborator Nominations](#collaborator-nominations)
14+
- [Onboarding](#onboarding)
15+
- [Consensus Seeking Process](#consensus-seeking-process)
16+
17+
<!-- /TOC -->
18+
719
## Collaborators
820

9-
The [nodejs/node](https://github.com/nodejs/node) GitHub repository is
10-
maintained by Collaborators who are added by the TSC on an ongoing basis.
21+
The [nodejs/node][] GitHub repository is maintained by Node.js Core
22+
Collaborators. Upon becoming Collaborators, they:
1123

12-
Individuals identified by the TSC as making significant and valuable
13-
contributions across any Node.js repository may be made Collaborators and given
14-
commit access to the project. Activities taken into consideration include (but
15-
are not limited to) the quality of:
24+
* Become members of the @nodejs/collaborators team
25+
* Gain individual membership of the Node.js foundation
1626

17-
* code commits and pull requests
18-
* documentation commits and pull requests
19-
* comments on issues and pull requests
20-
* contributions to the Node.js website
21-
* assistance provided to end users and novice contributors
22-
* participation in Working Groups
23-
* other participation in the wider Node.js community
27+
Their privileges include but are not limited to:
2428

25-
If individuals making valuable contributions do not believe they have been
26-
considered for commit access, they may log an issue or contact a TSC member
27-
directly.
29+
* Commit access to the [nodejs/node][] repository
30+
* Access to the Node.js continuous integration (CI) jobs
2831

2932
Modifications of the contents of the nodejs/node repository are made on
3033
a collaborative basis. Anybody with a GitHub account may propose a
@@ -49,27 +52,29 @@ Collaborators may opt to elevate significant or controversial modifications to
4952
the TSC by assigning the `tsc-review` label to a pull request or issue. The
5053
TSC should serve as the final arbiter where required.
5154

55+
See:
56+
5257
* [Current list of Collaborators](./README.md#current-project-team-members)
5358
* [A guide for Collaborators](./COLLABORATOR_GUIDE.md)
5459

5560
### Collaborator Activities
5661

5762
Typical activities of a Collaborator include:
5863

59-
* helping users and novice contributors
60-
* contributing code and documentation changes that improve the project
61-
* reviewing and commenting on issues and pull requests
62-
* participation in working groups
63-
* merging pull requests
64+
* Helping users and novice contributors
65+
* Contributing code and documentation changes that improve the project
66+
* Reviewing and commenting on issues and pull requests
67+
* Participation in working groups
68+
* Merging pull requests
6469

6570
The TSC periodically reviews the Collaborator list to identify inactive
6671
Collaborators. Past Collaborators are typically given _Emeritus_ status. Emeriti
6772
may request that the TSC restore them to active status.
6873

6974
## Technical Steering Committee
7075

71-
The Technical Steering Committee (TSC) has final authority over this project
72-
including:
76+
A subset of the Collaborators form the Technical Steering Committee (TSC).
77+
The TSC has final authority over this project, including:
7378

7479
* Technical direction
7580
* Project governance and process (including this policy)
@@ -78,7 +83,8 @@ including:
7883
* Conduct guidelines
7984
* Maintaining the list of additional Collaborators
8085

81-
* [Current list of TSC members](./README.md#current-project-team-members)
86+
The current list of TSC members can be found in
87+
[the project README](./README.md#current-project-team-members).
8288

8389
The operations of the TSC are governed by the [TSC Charter][] as approved by
8490
the Node.js Foundation Board of Directors.
@@ -128,10 +134,70 @@ the issue tracker is:
128134
either the proposal is dropped or the objecting members are persuaded. If
129135
there is an extended impasse, a motion for a vote may be made.
130136

137+
## Collaborator Nominations
138+
139+
Any existing Collaborator can nominate an individual making significant
140+
and valuable contributions across the Node.js organization to become a new
141+
Collaborator.
142+
143+
To nominate a new Collaborator, open an issue in the [nodejs/node][]
144+
repository, with a summary of the nominee's contributions, for example:
145+
146+
* Commits in the [nodejs/node][] repository.
147+
* Can be shown using the link
148+
`https://github.com/nodejs/node/commits?author=${GITHUB_ID}`
149+
(replace `${GITHUB_ID}` with the nominee's GitHub ID).
150+
* Pull requests and issues opened in the [nodejs/node][] repository.
151+
* Can be shown using the link
152+
`https://github.com/nodejs/node/pulls?q=author%3A${GITHUB_ID}+`
153+
* Comments and reviews on issues and pull requests in the
154+
[nodejs/node][] repository
155+
* Can be shown using the links
156+
`https://github.com/nodejs/node/pulls?q=reviewed-by%3A${GITHUB_ID}+`
157+
and `https://github.com/nodejs/node/pulls?q=commenter%3A${GITHUB_ID}+`
158+
* Assistance provided to end users and novice contributors
159+
* Participation in other projects, teams, and working groups of the
160+
Node.js organization
161+
* Can be shown using the links
162+
`https://github.com/search?q=author%3A${GITHUB_ID}++org%3Anodejs&type=Issues`
163+
and
164+
`https://github.com/search?q=commenter%3A${GITHUB_ID}++org%3Anodejs&type=Issues`
165+
* Other participation in the wider Node.js community
166+
167+
Mention @nodejs/collaborators in the issue to notify other Collaborators about
168+
the nomination.
169+
170+
If there are no objections raised by any Collaborators one week after
171+
the issue is opened, the nomination will be considered as accepted.
172+
Should there be any objections against the nomination, the TSC is responsible
173+
for working with the individuals involved and finding a resolution.
174+
The nomination must be approved by the TSC, which is assumed when there are no
175+
objections from any TSC members.
176+
177+
Prior to the public nomination, the Collaborator initiating it can seek
178+
feedback from other Collaborators in private using
179+
[the GitHub discussion page][collaborators-discussions] of the
180+
Collaborators team, and work with the nominee to improve the nominee's
181+
contribution profile, in order to make the nomination as frictionless
182+
as possible.
183+
184+
If individuals making valuable contributions do not believe they have been
185+
considered for a nomination, they may log an issue or contact a Collaborator
186+
directly.
187+
188+
### Onboarding
189+
190+
When the nomination is accepted, the new Collaborator will be onboarded
191+
by a TSC member. See [the onboarding guide](./doc/onboarding.md) on
192+
details of the onboarding process. In general, the onboarding should be
193+
completed within a month after the nomination is accepted.
194+
131195
## Consensus Seeking Process
132196

133197
The TSC follows a [Consensus Seeking][] decision making model as described by
134198
the [TSC Charter][].
135199

136-
[TSC Charter]: https://github.com/nodejs/TSC/blob/master/TSC-Charter.md
200+
[collaborators-discussions]: https://github.com/orgs/nodejs/teams/collaborators/discussions
137201
[Consensus Seeking]: https://en.wikipedia.org/wiki/Consensus-seeking_decision-making
202+
[TSC Charter]: https://github.com/nodejs/TSC/blob/master/TSC-Charter.md
203+
[nodejs/node]: https://github.com/nodejs/node

doc/onboarding.md

+2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ onboarding session.
99
GitHub account. Unless two-factor authentication is enabled, do not give an
1010
account elevated privileges such as the ability to land code in the main
1111
repository or to start continuous integration (CI) jobs.
12+
* Announce the accepted nomination in a TSC meeting and in the TSC
13+
mailing list.
1214

1315
## Fifteen minutes before the onboarding session
1416

0 commit comments

Comments
 (0)