Skip to content

Commit e6a2548

Browse files
tomgcoaddaleax
authored andcommitted
src: allow --perf-basic-prof-only-functions in NODE_OPTIONS
PR-URL: #25565 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent de587ba commit e6a2548

File tree

3 files changed

+6
-0
lines changed

3 files changed

+6
-0
lines changed

doc/api/cli.md

+1
Original file line numberDiff line numberDiff line change
@@ -712,6 +712,7 @@ V8 options that are allowed are:
712712
- `--abort-on-uncaught-exception`
713713
- `--max-old-space-size`
714714
- `--perf-basic-prof`
715+
- `--perf-basic-prof-only-functions`
715716
- `--perf-prof`
716717
- `--stack-trace-limit`
717718

src/node_options.cc

+4
Original file line numberDiff line numberDiff line change
@@ -299,6 +299,10 @@ PerIsolateOptionsParser::PerIsolateOptionsParser() {
299299
kAllowedInEnvironment);
300300
AddOption("--max-old-space-size", "", V8Option{}, kAllowedInEnvironment);
301301
AddOption("--perf-basic-prof", "", V8Option{}, kAllowedInEnvironment);
302+
AddOption("--perf-basic-prof-only-functions",
303+
"",
304+
V8Option{},
305+
kAllowedInEnvironment);
302306
AddOption("--perf-prof", "", V8Option{}, kAllowedInEnvironment);
303307
AddOption("--stack-trace-limit", "", V8Option{}, kAllowedInEnvironment);
304308

test/parallel/test-cli-node-options.js

+1
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ expect('--trace-event-file-pattern {pid}-${rotation}.trace_events ' +
3838

3939
if (!common.isWindows) {
4040
expect('--perf-basic-prof', 'B\n');
41+
expect('--perf-basic-prof-only-functions', 'B\n');
4142
}
4243

4344
if (common.isLinux && ['arm', 'x64'].includes(process.arch)) {

0 commit comments

Comments
 (0)