Skip to content

Commit e845155

Browse files
LiviaMedeirosUlisesGascon
authored andcommitted
benchmark: use tmpdir.resolve()
PR-URL: #49137 Refs: #49079 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
1 parent 7a80834 commit e845155

14 files changed

+14
-33
lines changed

benchmark/esm/cjs-parse.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@ const common = require('../common.js');
55
const { strictEqual } = require('assert');
66

77
const tmpdir = require('../../test/common/tmpdir');
8-
const benchmarkDirectory =
9-
path.resolve(tmpdir.path, 'benchmark-esm-parse');
8+
const benchmarkDirectory = tmpdir.resolve('benchmark-esm-parse');
109

1110
const bench = common.createBenchmark(main, {
1211
n: [1e2],

benchmark/esm/esm-legacyMainResolve.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ const common = require('../common.js');
88
const tmpdir = require('../../test/common/tmpdir.js');
99
const { pathToFileURL } = require('node:url');
1010

11-
const benchmarkDirectory =
12-
path.resolve(tmpdir.path, 'benchmark-import-meta-resolve');
11+
const benchmarkDirectory = tmpdir.resolve('benchmark-import-meta-resolve');
1312

1413
const configs = {
1514
n: [1e4],

benchmark/esm/esm-loader-defaultResolve.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,7 @@ const common = require('../common.js');
88
const tmpdir = require('../../test/common/tmpdir.js');
99
const { pathToFileURL } = require('node:url');
1010

11-
const benchmarkDirectory =
12-
path.resolve(tmpdir.path, 'benchmark-import-meta-resolve');
11+
const benchmarkDirectory = tmpdir.resolve('benchmark-import-meta-resolve');
1312

1413
const parentURL = pathToFileURL(path.join(benchmarkDirectory, 'entry-point.js'));
1514

benchmark/fs/read-stream-throughput.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
11
// Test the throughput of the fs.WriteStream class.
22
'use strict';
33

4-
const path = require('path');
54
const common = require('../common.js');
65
const fs = require('fs');
76
const assert = require('assert');
87

98
const tmpdir = require('../../test/common/tmpdir');
109
tmpdir.refresh();
11-
const filename = path.resolve(tmpdir.path,
12-
`.removeme-benchmark-garbage-${process.pid}`);
10+
const filename = tmpdir.resolve(`.removeme-benchmark-garbage-${process.pid}`);
1311

1412
const bench = common.createBenchmark(main, {
1513
encodingType: ['buf', 'asc', 'utf'],

benchmark/fs/readfile-permission-enabled.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,13 @@
33
// Then see how many times it got called.
44
'use strict';
55

6-
const path = require('path');
76
const common = require('../common.js');
87
const fs = require('fs');
98
const assert = require('assert');
109

1110
const tmpdir = require('../../test/common/tmpdir');
1211
tmpdir.refresh();
13-
const filename = path.resolve(tmpdir.path,
14-
`.removeme-benchmark-garbage-${process.pid}`);
12+
const filename = tmpdir.resolve(`.removeme-benchmark-garbage-${process.pid}`);
1513

1614
const bench = common.createBenchmark(main, {
1715
duration: [5],

benchmark/fs/readfile-promises.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,13 @@
33
// Yes, this is a silly benchmark. Most benchmarks are silly.
44
'use strict';
55

6-
const path = require('path');
76
const common = require('../common.js');
87
const fs = require('fs');
98
const assert = require('assert');
109

1110
const tmpdir = require('../../test/common/tmpdir');
1211
tmpdir.refresh();
13-
const filename = path.resolve(tmpdir.path,
14-
`.removeme-benchmark-garbage-${process.pid}`);
12+
const filename = tmpdir.resolve(`.removeme-benchmark-garbage-${process.pid}`);
1513

1614
const bench = common.createBenchmark(main, {
1715
duration: [5],

benchmark/fs/readfile.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,13 @@
33
// Yes, this is a silly benchmark. Most benchmarks are silly.
44
'use strict';
55

6-
const path = require('path');
76
const common = require('../common.js');
87
const fs = require('fs');
98
const assert = require('assert');
109

1110
const tmpdir = require('../../test/common/tmpdir');
1211
tmpdir.refresh();
13-
const filename = path.resolve(tmpdir.path,
14-
`.removeme-benchmark-garbage-${process.pid}`);
12+
const filename = tmpdir.resolve(`.removeme-benchmark-garbage-${process.pid}`);
1513

1614
const bench = common.createBenchmark(main, {
1715
duration: [5],

benchmark/fs/write-stream-throughput.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
11
// Test the throughput of the fs.WriteStream class.
22
'use strict';
33

4-
const path = require('path');
54
const common = require('../common.js');
65
const fs = require('fs');
76

87
const tmpdir = require('../../test/common/tmpdir');
98
tmpdir.refresh();
10-
const filename = path.resolve(tmpdir.path,
11-
`.removeme-benchmark-garbage-${process.pid}`);
9+
const filename = tmpdir.resolve(`.removeme-benchmark-garbage-${process.pid}`);
1210

1311
const bench = common.createBenchmark(main, {
1412
dur: [5],

benchmark/fs/writefile-promises.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,13 @@
33
// Yes, this is a silly benchmark. Most benchmarks are silly.
44
'use strict';
55

6-
const path = require('path');
76
const common = require('../common.js');
87
const fs = require('fs');
98
const assert = require('assert');
109
const tmpdir = require('../../test/common/tmpdir');
1110

1211
tmpdir.refresh();
13-
const filename = path.resolve(tmpdir.path,
14-
`.removeme-benchmark-garbage-${process.pid}`);
12+
const filename = tmpdir.resolve(`.removeme-benchmark-garbage-${process.pid}`);
1513
let filesWritten = 0;
1614
const bench = common.createBenchmark(main, {
1715
duration: [5],

benchmark/module/module-loader-circular.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,7 @@ const path = require('path');
44
const common = require('../common.js');
55

66
const tmpdir = require('../../test/common/tmpdir');
7-
const benchmarkDirectory =
8-
path.resolve(tmpdir.path, 'benchmark-module-circular');
7+
const benchmarkDirectory = tmpdir.resolve('benchmark-module-circular');
98

109
const bench = common.createBenchmark(main, {
1110
n: [1e4],

benchmark/module/module-loader-deep.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
'use strict';
22
const fs = require('fs');
3-
const path = require('path');
43
const common = require('../common.js');
54

65
const tmpdir = require('../../test/common/tmpdir');
7-
const benchmarkDirectory = path.join(tmpdir.path, 'nodejs-benchmark-module');
6+
const benchmarkDirectory = tmpdir.resolve('nodejs-benchmark-module');
87

98
const bench = common.createBenchmark(main, {
109
ext: ['', '.js'],

benchmark/module/module-loader.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const { builtinModules } = require('module');
55
const common = require('../common.js');
66

77
const tmpdir = require('../../test/common/tmpdir');
8-
let benchmarkDirectory = path.join(tmpdir.path, 'nodejs-benchmark-module');
8+
let benchmarkDirectory = tmpdir.resolve('nodejs-benchmark-module');
99

1010
// Filter all irregular modules.
1111
const otherModules = builtinModules.filter((name) => !/\/|^_|^sys/.test(name));

benchmark/module/module-require.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
'use strict';
22

33
const fs = require('fs');
4-
const path = require('path');
54
const common = require('../common.js');
65
const tmpdir = require('../../test/common/tmpdir');
7-
const benchmarkDirectory = path.join(tmpdir.path, 'nodejs-benchmark-module');
6+
const benchmarkDirectory = tmpdir.resolve('nodejs-benchmark-module');
87

98
const bench = common.createBenchmark(main, {
109
type: ['.js', '.json', 'dir'],

benchmark/process/coverage.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,11 @@ const common = require('../common.js');
66
const bench = common.createBenchmark(main, {
77
n: [1e5],
88
});
9-
const path = require('path');
109
const { rmSync } = require('fs');
1110
const { spawnSync } = require('child_process');
1211
const tmpdir = require('../../test/common/tmpdir');
1312

14-
const coverageDir = path.join(tmpdir.path, `./cov-${Date.now()}`);
13+
const coverageDir = tmpdir.resolve(`cov-${Date.now()}`);
1514

1615
function main({ n }) {
1716
bench.start();

0 commit comments

Comments
 (0)