Skip to content

Commit e917a23

Browse files
committed
url: move process.binding('url') to internalBinding
PR-URL: #22204 Refs: #22160 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
1 parent 83c1ba3 commit e917a23

File tree

4 files changed

+6
-3
lines changed

4 files changed

+6
-3
lines changed

lib/internal/bootstrap/node.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -375,7 +375,8 @@
375375
'tcp_wrap',
376376
'tls_wrap',
377377
'util',
378-
'async_wrap']);
378+
'async_wrap',
379+
'url']);
379380
process.binding = function binding(name) {
380381
return internalBindingWhitelist.has(name) ?
381382
internalBinding(name) :

lib/internal/url.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ let querystring;
3737
const { platform } = process;
3838
const isWindows = platform === 'win32';
3939

40+
const { internalBinding } = require('internal/bootstrap/loaders');
4041
const {
4142
domainToASCII: _domainToASCII,
4243
domainToUnicode: _domainToUnicode,
@@ -60,7 +61,7 @@ const {
6061
kPort,
6162
kQuery,
6263
kSchemeStart
63-
} = process.binding('url');
64+
} = internalBinding('url');
6465

6566
const context = Symbol('context');
6667
const cannotBeBase = Symbol('cannot-be-base');

src/node_url.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -2420,4 +2420,4 @@ static void Initialize(Local<Object> target,
24202420
} // namespace url
24212421
} // namespace node
24222422

2423-
NODE_BUILTIN_MODULE_CONTEXT_AWARE(url, node::url::Initialize)
2423+
NODE_MODULE_CONTEXT_AWARE_INTERNAL(url, node::url::Initialize)

test/parallel/test-process-binding-internalbinding-whitelist.js

+1
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,4 @@ assert(process.binding('v8'));
1212
assert(process.binding('stream_wrap'));
1313
assert(process.binding('signal_wrap'));
1414
assert(process.binding('contextify'));
15+
assert(process.binding('url'));

0 commit comments

Comments
 (0)