Skip to content

Commit ea90776

Browse files
erin-bushjasnell
authored andcommitted
test: swap expected and actual arguments in assert.strictEqual()
PR-URL: #23542 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 33351a1 commit ea90776

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

test/pummel/test-net-pingpong-delay.js

+12-12
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,11 @@ function pingPongTest(port, host, on_complete) {
3535

3636
socket.on('data', function(data) {
3737
console.log(data);
38-
assert.strictEqual('PING', data);
39-
assert.strictEqual('open', socket.readyState);
40-
assert.strictEqual(true, count <= N);
38+
assert.strictEqual(data, 'PING');
39+
assert.strictEqual(socket.readyState, 'open');
40+
assert.strictEqual(count <= N, true);
4141
setTimeout(function() {
42-
assert.strictEqual('open', socket.readyState);
42+
assert.strictEqual(socket.readyState, 'open');
4343
socket.write('PONG');
4444
}, DELAY);
4545
});
@@ -51,14 +51,14 @@ function pingPongTest(port, host, on_complete) {
5151

5252
socket.on('end', function() {
5353
console.log('server-side socket EOF');
54-
assert.strictEqual('writeOnly', socket.readyState);
54+
assert.strictEqual(socket.readyState, 'writeOnly');
5555
socket.end();
5656
});
5757

5858
socket.on('close', function(had_error) {
5959
console.log('server-side socket.end');
60-
assert.strictEqual(false, had_error);
61-
assert.strictEqual('closed', socket.readyState);
60+
assert.strictEqual(had_error, false);
61+
assert.strictEqual(socket.readyState, 'closed');
6262
socket.server.close();
6363
});
6464
});
@@ -69,17 +69,17 @@ function pingPongTest(port, host, on_complete) {
6969
client.setEncoding('utf8');
7070

7171
client.on('connect', function() {
72-
assert.strictEqual('open', client.readyState);
72+
assert.strictEqual(client.readyState, 'open');
7373
client.write('PING');
7474
});
7575

7676
client.on('data', function(data) {
7777
console.log(data);
78-
assert.strictEqual('PONG', data);
79-
assert.strictEqual('open', client.readyState);
78+
assert.strictEqual(data, 'PONG');
79+
assert.strictEqual(client.readyState, 'open');
8080

8181
setTimeout(function() {
82-
assert.strictEqual('open', client.readyState);
82+
assert.strictEqual(client.readyState, 'open');
8383
if (count++ < N) {
8484
client.write('PING');
8585
} else {
@@ -97,7 +97,7 @@ function pingPongTest(port, host, on_complete) {
9797

9898
client.on('close', common.mustCall(function() {
9999
console.log('client.end');
100-
assert.strictEqual(N + 1, count);
100+
assert.strictEqual(count, N + 1);
101101
assert.ok(client_ended);
102102
if (on_complete) on_complete();
103103
}));

0 commit comments

Comments
 (0)