Skip to content

Commit eab916c

Browse files
committed
crypto: move process.binding('tls_wrap') internal
This commit makes the tls_wrap builtin an internal builtin, and changes usage of the builtin from using process.binding('tls_wrap') to use internalBinding instead. Refs: #22160 PR-URL: #22429 Refs: #22160 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 656da16 commit eab916c

File tree

5 files changed

+8
-5
lines changed

5 files changed

+8
-5
lines changed

lib/_tls_wrap.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ const common = require('_tls_common');
3232
const { StreamWrap } = require('_stream_wrap');
3333
const { Buffer } = require('buffer');
3434
const debug = util.debuglog('tls');
35-
const tls_wrap = process.binding('tls_wrap');
3635
const { internalBinding } = require('internal/bootstrap/loaders');
3736
const { TCP, constants: TCPConstants } = internalBinding('tcp_wrap');
37+
const tls_wrap = internalBinding('tls_wrap');
3838
const { Pipe, constants: PipeConstants } = process.binding('pipe_wrap');
3939
const { owner_symbol } = require('internal/async_hooks').symbols;
4040
const { SecureContext: NativeSecureContext } = internalBinding('crypto');

lib/internal/bootstrap/node.js

+2-1
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,8 @@
353353
'signal_wrap',
354354
'crypto',
355355
'contextify',
356-
'tcp_wrap']);
356+
'tcp_wrap',
357+
'tls_wrap']);
357358
process.binding = function binding(name) {
358359
return internalBindingWhitelist.has(name) ?
359360
internalBinding(name) :

src/tls_wrap.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -915,4 +915,4 @@ void TLSWrap::Initialize(Local<Object> target,
915915

916916
} // namespace node
917917

918-
NODE_BUILTIN_MODULE_CONTEXT_AWARE(tls_wrap, node::TLSWrap::Initialize)
918+
NODE_MODULE_CONTEXT_AWARE_INTERNAL(tls_wrap, node::TLSWrap::Initialize)
+3-1
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,13 @@
1+
// Flags: --expose-internals
12
'use strict';
23

34
const common = require('../common');
45
if (!common.hasCrypto)
56
common.skip('missing crypto');
67

78
const util = require('util');
8-
const TLSWrap = process.binding('tls_wrap').TLSWrap;
9+
const { internalBinding } = require('internal/test/binding');
10+
const TLSWrap = internalBinding('tls_wrap').TLSWrap;
911

1012
// This will abort if internal pointer is not set to nullptr.
1113
util.inspect(new TLSWrap());

test/sequential/test-async-wrap-getasyncid.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ if (common.hasCrypto) { // eslint-disable-line node-core/crypto-check
266266
const credentials = require('tls').createSecureContext({ ca, cert, key });
267267

268268
// TLSWrap is exposed, but needs to be instantiated via tls_wrap.wrap().
269-
const tls_wrap = process.binding('tls_wrap');
269+
const tls_wrap = internalBinding('tls_wrap');
270270
testInitialized(
271271
tls_wrap.wrap(tcp._externalStream, credentials.context, true), 'TLSWrap');
272272
}

0 commit comments

Comments
 (0)