Skip to content

Commit ec74098

Browse files
thefourtheyeMylesBorins
authored andcommitted
build: make node-gyp output silent
As it is, node-gyp produces a lot of build related verbose messages. Latest node-gyp upgrade allows us to specify --silent flag to suppress those messages. Except for CI, addons build will run silently. PR-URL: #8990 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org>
1 parent c444119 commit ec74098

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

Makefile

+5-1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ PREFIX ?= /usr/local
88
FLAKY_TESTS ?= run
99
TEST_CI_ARGS ?=
1010
STAGINGSERVER ?= node-www
11+
LOGLEVEL ?= silent
1112

1213
OSTYPE := $(shell uname -s | tr '[A-Z]' '[a-z]')
1314

@@ -150,7 +151,8 @@ test/addons/.buildstamp: config.gypi \
150151
# Cannot use $(wildcard test/addons/*/) here, it's evaluated before
151152
# embedded addons have been generated from the documentation.
152153
for dirname in test/addons/*/; do \
153-
$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \
154+
echo "\nRunning addons test $$PWD/$$dirname" ; \
155+
$(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp --loglevel=$(LOGLEVEL) rebuild \
154156
--python="$(PYTHON)" \
155157
--directory="$$PWD/$$dirname" \
156158
--nodedir="$$PWD"; \
@@ -180,6 +182,7 @@ CI_NATIVE_SUITES := addons
180182
CI_JS_SUITES := doctool message parallel pseudo-tty sequential
181183

182184
# Build and test addons without building anything else
185+
test-ci-native: LOGLEVEL := info
183186
test-ci-native: | test/addons/.buildstamp
184187
$(PYTHON) tools/test.py -p tap --logfile test.tap \
185188
--mode=release --flaky-tests=$(FLAKY_TESTS) \
@@ -191,6 +194,7 @@ test-ci-js:
191194
--mode=release --flaky-tests=$(FLAKY_TESTS) \
192195
$(TEST_CI_ARGS) $(CI_JS_SUITES)
193196

197+
test-ci: LOGLEVEL := info
194198
test-ci: | build-addons
195199
out/Release/cctest --gtest_output=tap:cctest.tap
196200
$(PYTHON) tools/test.py -p tap --logfile test.tap --mode=release --flaky-tests=$(FLAKY_TESTS) \

0 commit comments

Comments
 (0)