Skip to content

Commit ecbb757

Browse files
richardlautargos
authored andcommitted
tools: fix make-v8.sh
V8's `tools/dev/v8gen.py` does not like being passed an empty string (`""`). PR-URL: #36594 Refs: #36099 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
1 parent 22ac227 commit ecbb757

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

tools/make-v8.sh

+2-1
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ if [ "$ARCH" = "s390x" ] || [ "$ARCH" = "ppc64le" ]; then
3636
gn gen -v "out.gn/$BUILD_ARCH_TYPE" --args="is_component_build=false is_debug=false use_goma=false goma_dir=\"None\" use_custom_libcxx=false v8_target_cpu=\"$TARGET_ARCH\" target_cpu=\"$TARGET_ARCH\" v8_enable_backtrace=true"
3737
ninja -v -C "out.gn/$BUILD_ARCH_TYPE" d8 cctest inspector-test
3838
else
39-
PATH=~/_depot_tools:$PATH tools/dev/v8gen.py "$BUILD_ARCH_TYPE" --no-goma "$V8_BUILD_OPTIONS"
39+
# shellcheck disable=SC2086
40+
PATH=~/_depot_tools:$PATH tools/dev/v8gen.py "$BUILD_ARCH_TYPE" --no-goma $V8_BUILD_OPTIONS
4041
PATH=~/_depot_tools:$PATH ninja -C "out.gn/$BUILD_ARCH_TYPE/" d8 cctest inspector-test
4142
fi

0 commit comments

Comments
 (0)