Skip to content

Commit ee85eb9

Browse files
SimenBTrott
authored andcommitted
doc: importModuleDynamically gets Script, not Module
PR-URL: #35593 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
1 parent 9ce5a03 commit ee85eb9

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

doc/api/vm.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ changes:
9090
This option is part of the experimental modules API, and should not be
9191
considered stable.
9292
* `specifier` {string} specifier passed to `import()`
93-
* `module` {vm.Module}
93+
* `script` {vm.Script}
9494
* Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is
9595
recommended in order to take advantage of error tracking, and to avoid
9696
issues with namespaces that contain `then` function exports.
@@ -984,7 +984,7 @@ changes:
984984
This option is part of the experimental modules API, and should not be
985985
considered stable.
986986
* `specifier` {string} specifier passed to `import()`
987-
* `module` {vm.Module}
987+
* `script` {vm.Script}
988988
* Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is
989989
recommended in order to take advantage of error tracking, and to avoid
990990
issues with namespaces that contain `then` function exports.
@@ -1082,7 +1082,7 @@ changes:
10821082
This option is part of the experimental modules API, and should not be
10831083
considered stable.
10841084
* `specifier` {string} specifier passed to `import()`
1085-
* `module` {vm.Module}
1085+
* `script` {vm.Script}
10861086
* Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is
10871087
recommended in order to take advantage of error tracking, and to avoid
10881088
issues with namespaces that contain `then` function exports.
@@ -1161,7 +1161,7 @@ changes:
11611161
This option is part of the experimental modules API, and should not be
11621162
considered stable.
11631163
* `specifier` {string} specifier passed to `import()`
1164-
* `module` {vm.Module}
1164+
* `script` {vm.Script}
11651165
* Returns: {Module Namespace Object|vm.Module} Returning a `vm.Module` is
11661166
recommended in order to take advantage of error tracking, and to avoid
11671167
issues with namespaces that contain `then` function exports.

tools/doc/type-parser.js

+1
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,7 @@ const customTypesMap = {
206206
'URLSearchParams': 'url.html#url_class_urlsearchparams',
207207

208208
'vm.Module': 'vm.html#vm_class_vm_module',
209+
'vm.Script': 'vm.html#vm_class_vm_script',
209210
'vm.SourceTextModule': 'vm.html#vm_class_vm_sourcetextmodule',
210211

211212
'MessagePort': 'worker_threads.html#worker_threads_class_messageport',

0 commit comments

Comments
 (0)