Skip to content

Commit ef9139e

Browse files
sam-githubaddaleax
authored andcommitted
test: end tls gracefully, rather than destroy
The timing of destroy between client/server is undefined, but end is guaranteed to occur. PR-URL: #25508 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 7e9f5ea commit ef9139e

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

test/parallel/test-tls-sni-option.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,7 @@ let clientError;
115115

116116
const server = tls.createServer(serverOptions, function(c) {
117117
serverResults.push({ sni: c.servername, authorized: c.authorized });
118+
c.end();
118119
});
119120

120121
server.on('tlsClientError', function(err) {
@@ -135,7 +136,6 @@ function startTest() {
135136
clientResults.push(
136137
client.authorizationError &&
137138
(client.authorizationError === 'ERR_TLS_CERT_ALTNAME_INVALID'));
138-
client.destroy();
139139

140140
next();
141141
});

test/parallel/test-tls-sni-server-client.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ const clientResults = [];
8686

8787
const server = tls.createServer(serverOptions, function(c) {
8888
serverResults.push(c.servername);
89+
c.end();
8990
});
9091

9192
server.addContext('a.example.com', SNIContexts['a.example.com']);
@@ -107,7 +108,6 @@ function startTest() {
107108
clientResults.push(
108109
client.authorizationError &&
109110
(client.authorizationError === 'ERR_TLS_CERT_ALTNAME_INVALID'));
110-
client.destroy();
111111

112112
// Continue
113113
start();

0 commit comments

Comments
 (0)