Skip to content

Commit efee834

Browse files
committed
deps: V8: cherry-pick 717543bbf0ef
Original commit message: [zone]: fix build on msvc in wasm module Fix: nodejs/node-v8#172 Change-Id: Ibdbee76470ec8a4c20af7650dc5fac4602873430 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2414688 Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#70109} Refs: v8/v8@717543b PR-URL: #35415 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
1 parent b006fa8 commit efee834

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.12',
39+
'v8_embedder_string': '-node.13',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/src/wasm/wasm-module-builder.h

+2
Original file line numberDiff line numberDiff line change
@@ -361,6 +361,8 @@ class V8_EXPORT_PRIVATE WasmModuleBuilder : public ZoneObject {
361361
// Indirect functions must be allocated before adding extra tables.
362362
bool allocating_indirect_functions_allowed_ = true;
363363
#endif
364+
365+
DISALLOW_COPY_AND_ASSIGN(WasmModuleBuilder);
364366
};
365367

366368
inline FunctionSig* WasmFunctionBuilder::signature() {

0 commit comments

Comments
 (0)