Skip to content

Commit effb121

Browse files
ryzokukentargos
authored andcommitted
test: rename test-regress-GH-1726
Rename the test appropriately alongside mentioning the subsystem Also, make a few basic changes to make sure the test conforms to the standard test structure Refs: #19105 Refs: https://github.com/nodejs/node/blob/master/doc/guides/writing-tests.md#test-structure PR-URL: #19161 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
1 parent fae0c44 commit effb121

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

test/sequential/test-regress-GH-1726.js test/sequential/test-regress-child_process-exit.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,13 @@
2020
// USE OR OTHER DEALINGS IN THE SOFTWARE.
2121

2222
'use strict';
23+
require('../common');
24+
2325
// Open a chain of five Node processes each a child of the next. The final
24-
// process exits immediately. Each process in the chain is instructed to
25-
// exit when its child exits.
26+
// process exits immediately. Each process in the chain is instructed to exit
27+
// when its child exits.
2628
// https://github.com/joyent/node/issues/1726
2729

28-
require('../common');
2930
const assert = require('assert');
3031
const ch = require('child_process');
3132

0 commit comments

Comments
 (0)