Skip to content

Commit f00ba6b

Browse files
danbevFishrock123
authored andcommitted
src: fix http2 debug build errors
Currently building with debug enabled produces the following errors: In file included from ../src/node_http2.h:6: ../src/node_http2_core-inl.h:465:18: error: expected ';' after do/while statement CHECK_GT(id, 0) ^ ; ../src/node_http2_core-inl.h:469:18: error: use of undeclared identifier 'spec' OnPriority(id, spec.stream_id, spec.weight, spec.exclusive); ^ ../src/node_http2_core-inl.h:469:34: error: use of undeclared identifier 'spec' OnPriority(id, spec.stream_id, spec.weight, spec.exclusive); ^ ../src/node_http2_core-inl.h:469:47: error: use of undeclared identifier 'spec' OnPriority(id, spec.stream_id, spec.weight, spec.exclusive); ^ This commit adds the missing semicolon to fix the above error. ../src/node_http2.cc:92:9: error: reference to non-static member function must be called; did you mean to call it with no arguments? CHECK(object->Has(context, env()->ongetpadding_string()).FromJust()); ^~~~~~ ../src/util.h:120:20: note: expanded from macro 'CHECK' if (UNLIKELY(!(expr))) { \ ^~~~ ../src/util.h:107:44: note: expanded from macro 'UNLIKELY' For this issue I was not sure what the correct check would be so I've just commented it out and will update after feedback. PR-URL: #16432 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent 0d7e4d2 commit f00ba6b

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/node_http2.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ ssize_t Http2Session::OnCallbackPadding(size_t frameLen,
8989
Context::Scope context_scope(context);
9090

9191
#if defined(DEBUG) && DEBUG
92-
CHECK(object->Has(context, env()->ongetpadding_string()).FromJust());
92+
CHECK(object()->Has(context, env()->ongetpadding_string()).FromJust());
9393
#endif
9494

9595
AliasedBuffer<uint32_t, v8::Uint32Array>& buffer =

src/node_http2_core-inl.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ inline void Nghttp2Session::HandlePriorityFrame(const nghttp2_frame* frame) {
462462
// good here
463463

464464
#if defined(DEBUG) && DEBUG
465-
CHECK_GT(id, 0)
465+
CHECK_GT(id, 0);
466466
#endif
467467

468468
nghttp2_priority_spec spec = priority_frame.pri_spec;

0 commit comments

Comments
 (0)