Skip to content

Commit f0202a7

Browse files
Trottaddaleax
authored andcommitted
test: fix test/pummel/test-fs-largefile.js
test-fs-largefile.js calls `fs.close()` without a callback which results in an error as of Node.js 10.0.0. Add a `common.mustCall()` callback so the test passes again. PR-URL: #25372 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
1 parent f58b530 commit f0202a7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/pummel/test-fs-largefile.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
// USE OR OTHER DEALINGS IN THE SOFTWARE.
2121

2222
'use strict';
23-
require('../common');
23+
const common = require('../common');
2424

2525
const assert = require('assert');
2626
const fs = require('fs');
@@ -46,7 +46,7 @@ assert.strictEqual(readBuf[0], 0);
4646

4747
// Verify that floating point positions do not throw.
4848
fs.writeSync(fd, writeBuf, 0, writeBuf.length, 42.000001);
49-
fs.close(fd);
49+
fs.close(fd, common.mustCall());
5050

5151
// Normally, we don't clean up tmp files at the end of a test, but we'll make an
5252
// exception for a 5 GB file.

0 commit comments

Comments
 (0)