Skip to content

Commit f1d3fb0

Browse files
dnlupaddaleax
authored andcommitted
benchmark: use let instead of var in util
PR-URL: #31794 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 148df0a commit f1d3fb0

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

benchmark/util/inspect-array.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ const bench = common.createBenchmark(main, {
1515
});
1616

1717
function main({ n, len, type }) {
18-
var arr = Array(len);
19-
var i, opts;
18+
let arr = Array(len);
19+
let opts;
2020

2121
switch (type) {
2222
case 'denseArray_showHidden':
@@ -29,14 +29,14 @@ function main({ n, len, type }) {
2929
case 'sparseArray':
3030
break;
3131
case 'mixedArray':
32-
for (i = 0; i < n; i += 2)
32+
for (let i = 0; i < n; i += 2)
3333
arr[i] = i;
3434
break;
3535
default:
3636
throw new Error(`Unsupported type ${type}`);
3737
}
3838
bench.start();
39-
for (i = 0; i < n; i++) {
39+
for (let i = 0; i < n; i++) {
4040
util.inspect(arr, opts);
4141
}
4242
bench.end(n);

benchmark/util/inspect.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ function benchmark(n, obj, options) {
3737
}
3838

3939
function main({ method, n, option }) {
40-
var obj;
40+
let obj;
4141
const options = opts[option];
4242
switch (method) {
4343
case 'Object':

benchmark/util/normalize-encoding.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,11 @@ function getInput(input) {
4646
function main({ input, n }) {
4747
const { normalizeEncoding } = require('internal/util');
4848
const inputs = getInput(input);
49-
var noDead = '';
49+
let noDead = '';
5050

5151
bench.start();
52-
for (var i = 0; i < n; ++i) {
53-
for (var j = 0; j < inputs.length; ++j) {
52+
for (let i = 0; i < n; ++i) {
53+
for (let j = 0; j < inputs.length; ++j) {
5454
noDead = normalizeEncoding(inputs[j]);
5555
}
5656
}

0 commit comments

Comments
 (0)