Skip to content

Commit f31292d

Browse files
joyeecheungBridgeAR
authored andcommitted
src: move C++ binding/addon related code into node_binding{.h, .cc}
This patch: - Moves the C++ binding/addon related code out of node_internals.h/node.cc and into dedicated files node_binding.h/node_binding.cc, and only puts the code resued by other files into the header. - Introduce a node::binding namespace so that code exposed to other files can be easily recognized. PR-URL: #24701 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
1 parent eab981e commit f31292d

File tree

6 files changed

+552
-509
lines changed

6 files changed

+552
-509
lines changed

node.gyp

+2
Original file line numberDiff line numberDiff line change
@@ -343,6 +343,7 @@
343343
'src/module_wrap.cc',
344344
'src/node.cc',
345345
'src/node_api.cc',
346+
'src/node_binding.cc',
346347
'src/node_buffer.cc',
347348
'src/node_config.cc',
348349
'src/node_constants.cc',
@@ -414,6 +415,7 @@
414415
'src/node.h',
415416
'src/node_api.h',
416417
'src/node_api_types.h',
418+
'src/node_binding.h',
417419
'src/node_buffer.h',
418420
'src/node_constants.h',
419421
'src/node_context_data.h',

0 commit comments

Comments
 (0)