Skip to content

Commit f4f191b

Browse files
joyeecheunggengjiawen
authored andcommitted
build: define NODE_EXPERIMENTAL_QUIC in mkcodecache and node_mksnapshot
Otherwise the build would fail with `./configure --experimental-quic --ninja` as the list of per-Environment values would not match and the code cache builder would not generate code cache for the quic JS sources. This is more or less a band-aid - a proper fix would be to aggregate these flags into something that can be included by all these different binary targets. See #31074. PR-URL: #34454 Fixes: #34435 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
1 parent 07b3aae commit f4f191b

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

node.gyp

+10
Original file line numberDiff line numberDiff line change
@@ -1376,6 +1376,11 @@
13761376
'HAVE_OPENSSL=1',
13771377
],
13781378
}],
1379+
[ 'node_use_openssl=="true" and experimental_quic==1', {
1380+
'defines': [
1381+
'NODE_EXPERIMENTAL_QUIC=1',
1382+
],
1383+
}],
13791384
['v8_enable_inspector==1', {
13801385
'defines': [
13811386
'HAVE_INSPECTOR=1',
@@ -1430,6 +1435,11 @@
14301435
'HAVE_OPENSSL=1',
14311436
],
14321437
}],
1438+
[ 'node_use_openssl=="true" and experimental_quic==1', {
1439+
'defines': [
1440+
'NODE_EXPERIMENTAL_QUIC=1',
1441+
],
1442+
}],
14331443
['v8_enable_inspector==1', {
14341444
'defines': [
14351445
'HAVE_INSPECTOR=1',

0 commit comments

Comments
 (0)