Skip to content

Commit f671dcb

Browse files
lukealbaorichardlau
authored andcommitted
test: unskip v8-updates/test-linux-perf-logger
Refs: #51308 Refs: #52821 PR-URL: #52869 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
1 parent c0c598d commit f671dcb

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

test/v8-updates/test-linux-perf-logger.js

+9-3
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,11 @@
2020
//
2121
// NOTE: This test runs only on linux, as that is the only platform supported by perf, and
2222
// accordingly the only platform where `perf-basic-prof*` v8 flags are available.
23-
23+
//
24+
// MAINTAINERS' NOTE: As of early 2024, the most common failure mode for this test suite
25+
// is for v8 options to change from version to version. If this suite fails, look there first.
26+
// We use options to forcibly require certain test cases to JIT code, and the nodeFlags to do
27+
// so can change.
2428

2529
const common = require('../common');
2630
if (!common.isLinux) {
@@ -48,7 +52,8 @@ const testCases = [
4852
},
4953
{
5054
title: '--perf-basic-prof compiled',
51-
nodeFlags: ['--perf-basic-prof', '--no-turbo-inlining', '--always-turbofan'],
55+
nodeFlags: ['--perf-basic-prof', '--no-turbo-inlining', '--always-turbofan',
56+
'--minimum-invocations-before-optimization=0'],
5257
matches: [
5358
'test-regex',
5459
'~functionOne .+/linux-perf-logger.js',
@@ -66,7 +71,8 @@ const testCases = [
6671
},
6772
{
6873
title: '--perf-basic-prof-only-functions compiled',
69-
nodeFlags: ['--perf-basic-prof-only-functions', '--no-turbo-inlining', '--always-turbofan'],
74+
nodeFlags: ['--perf-basic-prof-only-functions', '--no-turbo-inlining', '--always-turbofan',
75+
'--minimum-invocations-before-optimization=0'],
7076
matches: [
7177
'~functionOne .+/linux-perf-logger.js',
7278
'~functionTwo .+/linux-perf-logger.js',

0 commit comments

Comments
 (0)