Skip to content

Commit f824e40

Browse files
targosRafaelGSS
authored andcommitted
deps: remove usage of a C++20 feature from V8
We are not ready to compile with C++20 support yet. This is only a DCHECK that can be removed without affecting the behavior of release builds. PR-URL: #49639 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #52465 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
1 parent d2c84c9 commit f824e40

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737

3838
# Reset this number to 0 on major V8 upgrades.
3939
# Increment by one for each non-official patch applied to deps/v8.
40-
'v8_embedder_string': '-node.4',
40+
'v8_embedder_string': '-node.5',
4141

4242
##### V8 defaults for Node.js #####
4343

deps/v8/src/compiler/graph-visualizer.cc

-1
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,6 @@ void JsonPrintAllSourceWithPositionsWasm(
297297
os << "\"inlinings\": {";
298298
for (size_t i = 0; i < positions.size(); ++i) {
299299
if (i != 0) os << ", ";
300-
DCHECK(source_map.contains(positions[i].inlinee_func_index));
301300
size_t source_id = source_map.find(positions[i].inlinee_func_index)->second;
302301
SourcePosition inlining_pos = positions[i].caller_pos;
303302
os << '"' << i << "\": {\"inliningId\": " << i

0 commit comments

Comments
 (0)