src: print v8::OOMDetails::detail when it's available

joyeecheung · targos · commit f9075ff38e9c · 2024-06-20T14:40:42.000+02:00
This provides a bit more information when V8 runs out of memory. PR-URL: #53360 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
diff --git a/src/node_errors.cc b/src/node_errors.cc
@@ -600,6 +600,9 @@ void OOMErrorHandler(const char* location, const v8::OOMDetails& details) {
   } else {
     FPrintF(stderr, "FATAL ERROR: %s\n", message);
   }
+  if (details.detail != nullptr) {
+    FPrintF(stderr, "Reason: %s\n", details.detail);
+  }
 
   Isolate* isolate = Isolate::TryGetCurrent();
   bool report_on_fatalerror;

Original file line number	Diff line number	Diff line change
`@@ -600,6 +600,9 @@ void OOMErrorHandler(const char* location, const v8::OOMDetails& details) {`
`600`	`600`	`} else {`
`601`	`601`	`FPrintF(stderr, "FATAL ERROR: %s\n", message);`
`602`	`602`	`}`
	`603`	`+ if (details.detail != nullptr) {`
	`604`	`+ FPrintF(stderr, "Reason: %s\n", details.detail);`
	`605`	`+ }`
`603`	`606`
`604`	`607`	`Isolate* isolate = Isolate::TryGetCurrent();`
`605`	`608`	`bool report_on_fatalerror;`