Skip to content

Commit fa5c706

Browse files
TrottMylesBorins
authored andcommitted
test: refactor exitedAfterDisconnect test
* minor refactoring to conform with test-writing layout guidelines * rename test to use current terminology rather than deprecated terminology * assert.strictEqual() -> assert.ok() PR-URL: #16729 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
1 parent 1a633e3 commit fa5c706

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

test/parallel/test-cluster-disconnect-suicide-race.js test/parallel/test-cluster-disconnect-exitedAfterDisconnect-race.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
'use strict';
22

3+
const common = require('../common');
4+
35
// Test should fail in Node.js 5.4.1 and pass in later versions.
46

5-
const common = require('../common');
67
const assert = require('assert');
78
const cluster = require('cluster');
89

@@ -19,7 +20,7 @@ let eventFired = false;
1920
cluster.worker.disconnect();
2021

2122
process.nextTick(common.mustCall(() => {
22-
assert.strictEqual(eventFired, false, 'disconnect event should wait for ack');
23+
assert.ok(!eventFired, 'disconnect event should wait for ack');
2324
}));
2425

2526
cluster.worker.on('disconnect', common.mustCall(() => {

0 commit comments

Comments
 (0)