Skip to content

Commit facb606

Browse files
lpincadanielleadams
authored andcommitted
test: fix test-socket-write-after-fin-error
The `'error'` event is not emitted because the socket is already destroyed when `socket.write()` is called. Use the `socket.write()` callback instead. PR-URL: #42340 Refs: #42340 (comment) Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
1 parent bc51403 commit facb606

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

test/parallel/test-socket-write-after-fin-error.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -16,18 +16,18 @@ let gotServerError = false;
1616

1717
const server = net.createServer(function(sock) {
1818
sock.setEncoding('utf8');
19-
sock.on('error', function(er) {
20-
console.error(`${er.code}: ${er.message}`);
21-
gotServerError = er;
22-
});
19+
sock.on('error', function() {});
2320

2421
sock.on('data', function(c) {
2522
serverData += c;
2623
});
2724
sock.on('end', function() {
2825
gotServerEnd = true;
2926
setImmediate(() => {
30-
sock.write(serverData);
27+
sock.write(serverData, function(er) {
28+
console.error(`${er.code}: ${er.message}`);
29+
gotServerError = er;
30+
});
3131
sock.end();
3232
});
3333
});

0 commit comments

Comments
 (0)