Skip to content

Commit fbfd26d

Browse files
joyeecheungdanielleadams
authored andcommitted
src: move FsStatsOffset and kFsStatsBufferLength to node_file.h
To avoid bloating env.h, as they are only used in node_file.* PR-URL: #45498 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 581b38a commit fbfd26d

File tree

2 files changed

+27
-27
lines changed

2 files changed

+27
-27
lines changed

src/env.h

-27
Original file line numberDiff line numberDiff line change
@@ -98,33 +98,6 @@ class ModuleWrap;
9898
class Environment;
9999
class Realm;
100100

101-
enum class FsStatsOffset {
102-
kDev = 0,
103-
kMode,
104-
kNlink,
105-
kUid,
106-
kGid,
107-
kRdev,
108-
kBlkSize,
109-
kIno,
110-
kSize,
111-
kBlocks,
112-
kATimeSec,
113-
kATimeNsec,
114-
kMTimeSec,
115-
kMTimeNsec,
116-
kCTimeSec,
117-
kCTimeNsec,
118-
kBirthTimeSec,
119-
kBirthTimeNsec,
120-
kFsStatsFieldsNumber
121-
};
122-
123-
// Stat fields buffers contain twice the number of entries in an uv_stat_t
124-
// because `fs.StatWatcher` needs room to store 2 `fs.Stats` instances.
125-
constexpr size_t kFsStatsBufferLength =
126-
static_cast<size_t>(FsStatsOffset::kFsStatsFieldsNumber) * 2;
127-
128101
// Disables zero-filling for ArrayBuffer allocations in this scope. This is
129102
// similar to how we implement Buffer.allocUnsafe() in JS land.
130103
class NoArrayBufferZeroFillScope {

src/node_file.h

+27
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,33 @@ namespace fs {
1313

1414
class FileHandleReadWrap;
1515

16+
enum class FsStatsOffset {
17+
kDev = 0,
18+
kMode,
19+
kNlink,
20+
kUid,
21+
kGid,
22+
kRdev,
23+
kBlkSize,
24+
kIno,
25+
kSize,
26+
kBlocks,
27+
kATimeSec,
28+
kATimeNsec,
29+
kMTimeSec,
30+
kMTimeNsec,
31+
kCTimeSec,
32+
kCTimeNsec,
33+
kBirthTimeSec,
34+
kBirthTimeNsec,
35+
kFsStatsFieldsNumber
36+
};
37+
38+
// Stat fields buffers contain twice the number of entries in an uv_stat_t
39+
// because `fs.StatWatcher` needs room to store 2 `fs.Stats` instances.
40+
constexpr size_t kFsStatsBufferLength =
41+
static_cast<size_t>(FsStatsOffset::kFsStatsFieldsNumber) * 2;
42+
1643
class BindingData : public SnapshotableObject {
1744
public:
1845
explicit BindingData(Environment* env, v8::Local<v8::Object> wrap);

0 commit comments

Comments
 (0)