Skip to content

Commit fcfde57

Browse files
jasnelltargos
authored andcommitted
src: avoid using elevated v8 namespaces in node_perf.h
Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32468 Reviewed-By: Anna Henningsen <anna@addaleax.net>
1 parent 9600332 commit fcfde57

File tree

1 file changed

+15
-22
lines changed

1 file changed

+15
-22
lines changed

src/node_perf.h

+15-22
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,6 @@ class Environment;
1919

2020
namespace performance {
2121

22-
using v8::FunctionCallbackInfo;
23-
using v8::GCType;
24-
using v8::GCCallbackFlags;
25-
using v8::Local;
26-
using v8::Object;
27-
using v8::Value;
28-
2922
extern const uint64_t timeOrigin;
3023

3124
static inline const char* GetPerformanceMilestoneName(
@@ -60,9 +53,9 @@ class PerformanceEntry {
6053
public:
6154
static void Notify(Environment* env,
6255
PerformanceEntryType type,
63-
Local<Value> object);
56+
v8::Local<v8::Value> object);
6457

65-
static void New(const FunctionCallbackInfo<Value>& args);
58+
static void New(const v8::FunctionCallbackInfo<v8::Value>& args);
6659

6760
PerformanceEntry(Environment* env,
6861
const char* name,
@@ -76,7 +69,7 @@ class PerformanceEntry {
7669

7770
virtual ~PerformanceEntry() = default;
7871

79-
virtual v8::MaybeLocal<Object> ToObject() const;
72+
virtual v8::MaybeLocal<v8::Object> ToObject() const;
8073

8174
Environment* env() const { return env_; }
8275

@@ -105,27 +98,27 @@ class PerformanceEntry {
10598
};
10699

107100
enum PerformanceGCKind {
108-
NODE_PERFORMANCE_GC_MAJOR = GCType::kGCTypeMarkSweepCompact,
109-
NODE_PERFORMANCE_GC_MINOR = GCType::kGCTypeScavenge,
110-
NODE_PERFORMANCE_GC_INCREMENTAL = GCType::kGCTypeIncrementalMarking,
111-
NODE_PERFORMANCE_GC_WEAKCB = GCType::kGCTypeProcessWeakCallbacks
101+
NODE_PERFORMANCE_GC_MAJOR = v8::GCType::kGCTypeMarkSweepCompact,
102+
NODE_PERFORMANCE_GC_MINOR = v8::GCType::kGCTypeScavenge,
103+
NODE_PERFORMANCE_GC_INCREMENTAL = v8::GCType::kGCTypeIncrementalMarking,
104+
NODE_PERFORMANCE_GC_WEAKCB = v8::GCType::kGCTypeProcessWeakCallbacks
112105
};
113106

114107
enum PerformanceGCFlags {
115108
NODE_PERFORMANCE_GC_FLAGS_NO =
116-
GCCallbackFlags::kNoGCCallbackFlags,
109+
v8::GCCallbackFlags::kNoGCCallbackFlags,
117110
NODE_PERFORMANCE_GC_FLAGS_CONSTRUCT_RETAINED =
118-
GCCallbackFlags::kGCCallbackFlagConstructRetainedObjectInfos,
111+
v8::GCCallbackFlags::kGCCallbackFlagConstructRetainedObjectInfos,
119112
NODE_PERFORMANCE_GC_FLAGS_FORCED =
120-
GCCallbackFlags::kGCCallbackFlagForced,
113+
v8::GCCallbackFlags::kGCCallbackFlagForced,
121114
NODE_PERFORMANCE_GC_FLAGS_SYNCHRONOUS_PHANTOM_PROCESSING =
122-
GCCallbackFlags::kGCCallbackFlagSynchronousPhantomCallbackProcessing,
115+
v8::GCCallbackFlags::kGCCallbackFlagSynchronousPhantomCallbackProcessing,
123116
NODE_PERFORMANCE_GC_FLAGS_ALL_AVAILABLE_GARBAGE =
124-
GCCallbackFlags::kGCCallbackFlagCollectAllAvailableGarbage,
117+
v8::GCCallbackFlags::kGCCallbackFlagCollectAllAvailableGarbage,
125118
NODE_PERFORMANCE_GC_FLAGS_ALL_EXTERNAL_MEMORY =
126-
GCCallbackFlags::kGCCallbackFlagCollectAllExternalMemory,
119+
v8::GCCallbackFlags::kGCCallbackFlagCollectAllExternalMemory,
127120
NODE_PERFORMANCE_GC_FLAGS_SCHEDULE_IDLE =
128-
GCCallbackFlags::kGCCallbackScheduleIdleGarbageCollection
121+
v8::GCCallbackFlags::kGCCallbackScheduleIdleGarbageCollection
129122
};
130123

131124
class GCPerformanceEntry : public PerformanceEntry {
@@ -150,7 +143,7 @@ class GCPerformanceEntry : public PerformanceEntry {
150143
class ELDHistogram : public HandleWrap, public Histogram {
151144
public:
152145
ELDHistogram(Environment* env,
153-
Local<Object> wrap,
146+
v8::Local<v8::Object> wrap,
154147
int32_t resolution);
155148

156149
bool RecordDelta();

0 commit comments

Comments
 (0)