Skip to content

Commit fd6cc6e

Browse files
aduh95marco-ippolito
authored andcommitted
tools: do not run Corepack code before it's reviewed
Also enable running `make corepack-update` when `node`/`npm` is not available globally. PR-URL: #53405 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent b273c51 commit fd6cc6e

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

Makefile

+3-2
Original file line numberDiff line numberDiff line change
@@ -1151,13 +1151,14 @@ pkg: $(PKG)
11511151
.PHONY: corepack-update
11521152
corepack-update:
11531153
mkdir -p /tmp/node-corepack
1154-
curl -qLo /tmp/node-corepack/package.tgz "$$(npm view corepack dist.tarball)"
1154+
curl -qLo /tmp/node-corepack/package.tgz "$$($(call available-node,$(NPM) view corepack dist.tarball))"
11551155

11561156
rm -rf deps/corepack && mkdir deps/corepack
11571157
cd deps/corepack && tar xf /tmp/node-corepack/package.tgz --strip-components=1
11581158
chmod +x deps/corepack/shims/*
11591159

1160-
node deps/corepack/dist/corepack.js --version
1160+
$(call available-node,'-p' \
1161+
'require(`./deps/corepack/package.json`).version')
11611162

11621163
.PHONY: pkg-upload
11631164
# Note: this is strictly for release builds on release machines only.

0 commit comments

Comments
 (0)