Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit fd6cd46

Browse files
lpincaMylesBorins
authored andcommittedMar 20, 2018
net: remove redundant code from _writeGeneric()
The encoding is already handled by `Writable.prototype.write()`. PR-URL: #18429 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
1 parent 9e29fec commit fd6cd46

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed
 

‎lib/net.js

+1-7
Original file line numberDiff line numberDiff line change
@@ -767,13 +767,7 @@ Socket.prototype._writeGeneric = function(writev, data, encoding, cb) {
767767
// Retain chunks
768768
if (err === 0) req._chunks = chunks;
769769
} else {
770-
var enc;
771-
if (data instanceof Buffer) {
772-
enc = 'buffer';
773-
} else {
774-
enc = encoding;
775-
}
776-
err = createWriteReq(req, this._handle, data, enc);
770+
err = createWriteReq(req, this._handle, data, encoding);
777771
}
778772

779773
if (err)

0 commit comments

Comments
 (0)
Please sign in to comment.