Skip to content

Commit ffbb4e6

Browse files
jonask-wixMylesBorins
authored andcommitted
test: use default assertion message
In test-child-process-spawnsync, the assert.strictEqual() custom message was hiding information about why the test has failed. It just showed what value is expected and in case of failure we want to know which value has caused test to fail. PR-URL: #16819 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
1 parent dd558a5 commit ffbb4e6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/parallel/test-child-process-spawnsync.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const spawnSync = require('child_process').spawnSync;
77
// Echo does different things on Windows and Unix, but in both cases, it does
88
// more-or-less nothing if there are no parameters
99
const ret = spawnSync('sleep', ['0']);
10-
assert.strictEqual(ret.status, 0, 'exit status should be zero');
10+
assert.strictEqual(ret.status, 0);
1111

1212
// Error test when command does not exist
1313
const ret_err = spawnSync('command_does_not_exist', ['bar']).error;

0 commit comments

Comments
 (0)