Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: make lint-js should not lint test/tmp* #17029

Closed
bnoordhuis opened this issue Nov 14, 2017 · 6 comments
Closed

tools: make lint-js should not lint test/tmp* #17029

bnoordhuis opened this issue Nov 14, 2017 · 6 comments
Labels
good first issue Issues that are suitable for first-time contributors. help wanted Issues that need assistance from volunteers or PRs that need help to proceed.

Comments

@bnoordhuis
Copy link
Member

test/tmp (and test/tmp.0, test/tmp.1, etc.) sometimes have temporary files in them with a .js or .mjs suffix. The linter should not lint those. =)

cc @joyeecheung

@bnoordhuis bnoordhuis added good first issue Issues that are suitable for first-time contributors. help wanted Issues that need assistance from volunteers or PRs that need help to proceed. labels Nov 14, 2017
@priyank-p
Copy link
Contributor

priyank-p commented Nov 14, 2017

@bnoordhuis will adding test/temp and test/temp.* fix it?

@vorontsov-pavel
Copy link

vorontsov-pavel commented Nov 14, 2017

@cPhost yes, I tried. PS: excluding test/.tmp*

@Trott
Copy link
Member

Trott commented Nov 14, 2017

If you have a test/tmp, it is leftover from a long-ish time ago. (EDIT: Well, a few weeks ago at least.) We changed it to .tmp (leading .) to work around a issue with Windows/globbing/.eslintignore.

So just remove your test/tmp* directories and they should never be re-created and everything will be awesome.

@Trott
Copy link
Member

Trott commented Nov 14, 2017

I'm going to close this, but feel free to re-open if you think that's wrong-headed.

@Trott Trott closed this as completed Nov 14, 2017
@Trott
Copy link
Member

Trott commented Nov 14, 2017

Here's the PR that introduced the change. It landed 19 days ago so not a
long time ago but not terribly recent either. #16372

@joyeecheung
Copy link
Member

I have not checked if the tmp directories are ignored by git, but git clean -xfd ./test is probably a best practice when switching between branches..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that are suitable for first-time contributors. help wanted Issues that need assistance from volunteers or PRs that need help to proceed.
Projects
None yet
Development

No branches or pull requests

5 participants