Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that npm is runnable in tests #52891

Open
avivkeller opened this issue May 8, 2024 · 2 comments
Open

Verify that npm is runnable in tests #52891

avivkeller opened this issue May 8, 2024 · 2 comments
Labels
npm Issues and PRs related to the npm client dependency or the npm registry. test Issues and PRs related to the tests.

Comments

@avivkeller
Copy link
Member

Issues like #52682 and #52884 show that (sometimes) npm is not properly packaged in a release. I believe the tests should also check whether npm works properly to prevent issues like these from occurring.
@avivkeller avivkeller added test Issues and PRs related to the tests. npm Issues and PRs related to the npm client dependency or the npm registry. feature request Issues that request new features to be added to Node.js. labels May 8, 2024
@github-project-automation github-project-automation bot moved this to Pending Triage in Node.js feature requests May 8, 2024
@targos targos removed the feature request Issues that request new features to be added to Node.js. label May 8, 2024
@targos
Copy link
Member

targos commented May 8, 2024

It would be great to have such tests but that won't be easy!

@avivkeller
Copy link
Member Author

It would be great to have such tests but that won't be easy!

I agree that it won't be easy, but IMO this should be a goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
npm Issues and PRs related to the npm client dependency or the npm registry. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@targos @avivkeller