use intoiterator on populate_blocks and rename rpo var

Author: vezenovm

compiler/noirc_evaluator/src/ssa/opt/normalize_value_ids.rs

@@ -76,14 +76,14 @@ impl Context {
             new_function.dfg.make_global(value.get_type().into_owned());
         }
 
-        let reachable_blocks = old_function.reachable_blocks().into_iter().collect::<Vec<_>>();
-        self.new_ids.populate_blocks(&reachable_blocks, old_function, new_function);
+        let reachable_blocks = old_function.reachable_blocks();
+        self.new_ids.populate_blocks(reachable_blocks, old_function, new_function);
 
-        let mut rpo = PostOrder::with_function(old_function).into_vec();
-        rpo.reverse();
+        let mut reverse_post_order = PostOrder::with_function(old_function).into_vec();
+        reverse_post_order.reverse();
 
         // Map each parameter, instruction, and terminator
-        for old_block_id in rpo {
+        for old_block_id in reverse_post_order {
             let new_block_id = self.new_ids.blocks[&old_block_id];
 
             let old_block = &mut old_function.dfg[old_block_id];
@@ -140,21 +140,21 @@ impl Context {
 impl IdMaps {
     fn populate_blocks(
         &mut self,
-        reachable_blocks: &[BasicBlockId],
+        reachable_blocks: impl IntoIterator<Item = BasicBlockId>,
         old_function: &mut Function,
         new_function: &mut Function,
     ) {
         let old_entry = old_function.entry_block();
         self.blocks.insert(old_entry, new_function.entry_block());
 
         for old_id in reachable_blocks {
-            if *old_id != old_entry {
+            if old_id != old_entry {
                 let new_id = new_function.dfg.make_block();
-                self.blocks.insert(*old_id, new_id);
+                self.blocks.insert(old_id, new_id);
             }
 
-            let new_id = self.blocks[old_id];
-            let old_block = &mut old_function.dfg[*old_id];
+            let new_id = self.blocks[&old_id];
+            let old_block = &mut old_function.dfg[old_id];
             for old_parameter in old_block.take_parameters() {
                 let old_parameter = old_function.dfg.resolve(old_parameter);
                 let typ = old_function.dfg.type_of_value(old_parameter);