Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track down regression in nargo test speed in noir-bignum library #7219

Closed
TomAFrench opened this issue Jan 29, 2025 · 1 comment
Closed

Track down regression in nargo test speed in noir-bignum library #7219

TomAFrench opened this issue Jan 29, 2025 · 1 comment

Comments

@TomAFrench
Copy link
Member

There's been a significant regression in the time taken to run the test suite on https://github.com/noir-lang/noir-bignum.

On a recent commit we end up taking ~28x the time to run the test suite relative to the 1.0.0-beta.1 release.

Image

We should determine where this regression came in and address it.

@TomAFrench
Copy link
Member Author

This seems to be caused by #6969. Prior to nightly-2025-01-08 running nargo test on the current master of bignum run only 62 tests but after this nightly version we end up running 167 tests.

I'm closing this as the "better performance" we were getting before was due to us not running the full test suite.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant