Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize per-executor neotest coverage collection #3558

Open
AnnaShaleva opened this issue Aug 16, 2024 · 1 comment
Open

Optimize per-executor neotest coverage collection #3558

AnnaShaleva opened this issue Aug 16, 2024 · 1 comment
Labels
enhancement Improving existing functionality I3 Minimal impact neotest Neotest framework and coverage tool performance More of something per second S3 Minimally significant U4 Nothing urgent

Comments

@AnnaShaleva
Copy link
Member

Is your feature request related to a problem? Please describe.

#3462 enables neotest coverage, but it may be optimized. Currently covered OPs are stored in a global mutex-protected package-level variable and every Executor modifies it on every VM instruction handling. It slows our tests down if tests are running in parallel.

Describe the solution you'd like

Implement #3462 (comment).

Describe alternatives you've considered

No alternatives, the proposed solution fits perfectly.
@AnnaShaleva AnnaShaleva added I3 Minimal impact U4 Nothing urgent enhancement Improving existing functionality S3 Minimally significant labels Aug 16, 2024
@AnnaShaleva AnnaShaleva changed the title Optimize per-executor coverage collection Optimize per-executor neotest coverage collection Aug 16, 2024
@AnnaShaleva AnnaShaleva mentioned this issue Aug 16, 2024
Merged
@roman-khimov roman-khimov added the performance More of something per second label Aug 18, 2024
@roman-khimov
Copy link
Member

Makes sense.

@AnnaShaleva AnnaShaleva added the neotest Neotest framework and coverage tool label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improving existing functionality I3 Minimal impact neotest Neotest framework and coverage tool performance More of something per second S3 Minimally significant U4 Nothing urgent
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roman-khimov @AnnaShaleva