Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving away from proj/proj #678

Open
magnatelee opened this issue Apr 11, 2023 · 4 comments
Open

Moving away from proj/proj #678

magnatelee opened this issue Apr 11, 2023 · 4 comments
Assignees

Comments

@magnatelee
Copy link
Contributor

Having the legate directory at the top of the repository is in general a bad idea and seems to have been masking issues that would otherwise have been caught and fixed. We should move away from this directory structure. Here are a couple of options (feel free to make any suggestions):

  • Moving legate under a python directory at the top
  • Renaming the current src to cpp, and moving legate under the src directory. @bryevdv mentions that setuptools might special case this directory structure.
@bryevdv
Copy link
Contributor

bryevdv commented Apr 11, 2023

AFAICT setuptools support some automatic discovery for the case of src:

https://setuptools.pypa.io/en/latest/userguide/package_discovery.html#src-layout

But we already have outlier requirements so I am not sure automatic discovery would apply to us anyway.

Big 👍 to moving away from proj/proj in any capacity.

@manopapad
Copy link
Contributor

src for C++ and python for Python sounds good to me.

@magnatelee magnatelee self-assigned this Apr 12, 2023
@magnatelee
Copy link
Contributor Author

magnatelee commented Apr 12, 2023

Sounds good. I'll make a PR for this after two major refactoring changes (#675 and #676) get merged.

@magnatelee
Copy link
Contributor Author

Let's do this after #457 is merged too. Otherwise, there'll be a huge number of merge conflicts with that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants