Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add a max_versions configuration option to use in deployments #46

Closed
jprobinson opened this issue Feb 15, 2019 · 2 comments
Closed

Comments

@jprobinson
Copy link
Contributor

If supplied with a non-zero value along with the "deploy" action, after the deployment completes successfully, the plugin would delete any older versions beyond the "max version" count.

For example, if we added max_versions: 2 to deployment config and the deployed service had 4 total versions after the deployment completed, the plugin would remove the 2 older versions.

This is meant to deal with the limit of 210 versions for an App Engine project, which can be reached rather quickly if a large/active team is developing against the project. At the moment, reaching this 210 limit causes the plugin to error and developers must manually remove older versions from their projects. This should remove that manual intervention without requiring users to add any more moving parts to their deployment pipelines.

@saranrapjs
Copy link
Member

Presumably this would start deleting anything over max_versions at the oldest version? e.g. chronologically sorted?

@jprobinson
Copy link
Contributor Author

Correct, I'd think we'd cron-sort the versions and drop the oldest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants