Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrabbiata: avoid duplicated code for each curve #3071

Open
dannywillems opened this issue Feb 26, 2025 · 0 comments
Open

Arrabbiata: avoid duplicated code for each curve #3071

dannywillems opened this issue Feb 26, 2025 · 0 comments

Comments

@dannywillems
Copy link
Member

Initially, it has been decided to go with the KISS method, and avoid as much as possible complex type machinery to not have a Pickles-like version of Arrabbiata.
Over time, we realized that it was adding duplicated code like here or here. There is a consensus in the team that it should be improved. In particular, when introducing the cross-terms computation, we notice that it is getting even worse.

A solution would be to rely on the types to select which fields the environment should use and update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant