annotation-sample-link-to-recording.txt

{
  “@context”: “http://www.w3.org/ns/anno.jsonld”,
  “target”: [
    {
      “id”: “hello_MELD.mei”
    }
  ],
  “type”: “Annotation”,
  "body": [{
    "id": "Hello_MELD.mp3",
    "type": "Sound",
    "format": "audio/mp3"
  }],
  “motivation”: “linking”,
  “created”: “@@@@”,
  “creator”: “@@@@”,
  “@id”: “@@@@”
}


## Steps to add new annotation:

1. [x] Add new annotation type to `annotationSubmitter.render`;  assign value string

2. [x] Add new annotation type in `annotationSubmitter.submitHandler`

3. [-] Add new annotation type logic to `addAnnotations` - add new render option for recording link annotation in `render` method.  NOT NEEDED: uses `this.props.annotationType !== "cueMedia"` branch of render logic, so nothing more to do here.

4. [x] Look at annotation rendering in `AnnotationItem` (invoked by `AnnotationList`)..

    - the motivation for recording annotations needed to be changed in `annotationSubmitter.submitHandler`, as used to select rendered format.

5. [x] In `selectableScoreApp.onReceiveAnnotationContainerContent` code to handle new motivation type.


NOTE: appears to be no selection type for whole piece (e.g. no fragment). [POSTED in [music-scholars-annotator issue](https://github.com/trompamusic/music-scholars-annotator/issues/9).]

NOTE: new annotation motivation (currently "recording") should be reviewed.

NOTE: there is still a problem that annotations are not saved in the specified container - they all end up in "public/".  LATER: see line 22 in `solidWrapper.js`.  FIXED: need to also set state value in `solidWrapper.js` - fairly obvious, but one I missed first time around. [FIXED]

NOTE: meld-cli-tool needs better handling/reporting of authentication failure.  It seems that access to the Solid directory fails unless there is an explicit ACL set of the new folder. [DONE]

NOTE: in `annotationItem.js`, about line 600, code does crude attempt at URI resolution.  Better approach would be to use a URL handling library toi do the resolution properly.  rdflib.js includes https://github.com/linkeddata/rdflib.js/blob/master/src/uri.ts.  Or https://nodejs.org/api/url.html or even https://developer.mozilla.org/en-US/docs/Web/API/URL/URL may be better options.  [POSTED in [music-scholars-annotator issue](https://github.com/trompamusic/music-scholars-annotator/issues/9).]

NOTE: in `selectablScoreApp.js` it's not clear why the motivation switch logic is required - it appears to be setting class values on annotations.  E.g., why isn't this handled in `annotationItem.js`?  [POSTED in [music-scholars-annotator issue](https://github.com/trompamusic/music-scholars-annotator/issues/9).]

NOTE: try testing app against new Inrupt Solid pod server at https://signup.pod.inrupt.com/  [DONE.  Problems noted.  See https://github.com/trompamusic/music-scholars-annotator/issues/9]

NOTE: would have liked documentation of "<SelectableScore>" abstraction used.  [NOTED in SSI report].

NOTE: `music-scholars-annotation` code structure seems to entangle a number of different concerns; e.g. duplicated logic between `annotationItem.renderSwitch` and `selectableScoreApp.onReceiveAnnotationContainerContent` -- refactor for [DRY](https://en.wikipedia.org/wiki/Don%27t_repeat_yourself)?  [POSTED in [music-scholars-annotator issue](https://github.com/trompamusic/music-scholars-annotator/issues/9).]

A particular thought I had was that each annotation type should be implemented as a separate React element, with all of the associated logic keep in a single module.  Then, at the level of (something like) `annotationbSubmitter.js`/`annotationItem.js`, the appropriate annotation type element would be selected, and avoid the need for further tests.  Maybe use an "annotation object factory" element to encapsulate all the annotation switching logic?  [POSTED in [music-scholars-annotator issue](https://github.com/trompamusic/music-scholars-annotator/issues/9).]