🐛 Fixed crash in aero dashboard when resuming game.

Caused by bad material cleanup, introduced in 1cbf91f with the mouse-hover highlights.

Author: ohlidalp

source/main/gui/OverlayWrapper.cpp

@@ -1080,7 +1080,14 @@ void AeroEngineWidget::Setup(std::string const& engfire_elemname, std::string co
     // Because highlighting works on per-material basis, we must clone the material for each element
     engfire_element = Ogre::OverlayManager::getSingleton().getOverlayElement(engfire_elemname);
     thr_element = Ogre::OverlayManager::getSingleton().getOverlayElement(thr_elemname);
-    thr_element->setMaterial(thr_element->getMaterial()->clone(thr_element->getMaterial()->getName() + "@" + thr_elemname));
+    thr_material = thr_element->getMaterial()->clone(thr_element->getMaterial()->getName() + "@" + thr_elemname);
+    thr_element->setMaterial(thr_material);
+}
+
+AeroEngineWidget::~AeroEngineWidget()
+{
+    // Remove cloned materials
+    Ogre::MaterialManager::getSingleton().remove(thr_material);
 }
 
 bool AeroEngineWidget::UpdateMouseHover()
@@ -1119,6 +1126,13 @@ void AeroSwitchWidget::Setup(std::string const & elem_name, std::string const &
     off_material = Ogre::MaterialManager::getSingleton().getByName(mat_off)->clone(elem_name + "@" + mat_off);
 }
 
+AeroSwitchWidget::~AeroSwitchWidget()
+{
+    // Remove cloned materials
+    Ogre::MaterialManager::getSingleton().remove(on_material);
+    Ogre::MaterialManager::getSingleton().remove(off_material);
+}
+
 bool AeroSwitchWidget::UpdateMouseHover()
 {
     // Element's current material switches dynamically based on game state, we must always sync both variants.
@@ -1150,9 +1164,18 @@ void AeroTrimWidget::Setup(std::string const & up, std::string const & dn, std::
     // Because highlighting works on per-material basis, we must clone the material for each element
     display = Ogre::OverlayManager::getSingleton().getOverlayElement(disp);
     up_button = Ogre::OverlayManager::getSingleton().getOverlayElement(up);
-    up_button->setMaterial(up_button->getMaterial()->clone(up + "$" + disp));
+    up_material = up_button->getMaterial()->clone(up + "$" + disp);
+    up_button->setMaterial(up_material);
     dn_button = Ogre::OverlayManager::getSingleton().getOverlayElement(dn);
-    dn_button->setMaterial(dn_button->getMaterial()->clone(dn + "$" + disp));
+    down_material = dn_button->getMaterial()->clone(dn + "$" + disp);
+    dn_button->setMaterial(down_material);
+}
+
+AeroTrimWidget::~AeroTrimWidget()
+{
+    // Remove cloned materials
+    Ogre::MaterialManager::getSingleton().remove(up_material);
+    Ogre::MaterialManager::getSingleton().remove(down_material);
 }
 
 bool AeroTrimWidget::UpdateMouseHover()

source/main/gui/OverlayWrapper.h

@@ -44,11 +44,13 @@ struct AeroInteractiveWidget
 
 struct AeroEngineWidget : public AeroInteractiveWidget
 {
+    ~AeroEngineWidget();
     void Setup(std::string const& engfire_elemname, std::string const& thr_elemname);
     bool UpdateMouseHover() override;
     Ogre::OverlayElement* GetHoveredElement() const override;
 
     Ogre::OverlayElement *thr_element;
+    Ogre::MaterialPtr thr_material;
     Ogre::OverlayElement *engfire_element;
     Ogre::TextureUnitState *rpm_texture;
     Ogre::TextureUnitState *pitch_texture;
@@ -57,6 +59,7 @@ struct AeroEngineWidget : public AeroInteractiveWidget
 
 struct AeroSwitchWidget: public AeroInteractiveWidget
 {
+    ~AeroSwitchWidget();
     void Setup(std::string const & elem_name, std::string const & mat_on, std::string const & mat_off);
     void SetActive(bool value);
     bool UpdateMouseHover() override;
@@ -69,6 +72,7 @@ struct AeroSwitchWidget: public AeroInteractiveWidget
 
 struct AeroTrimWidget : public AeroInteractiveWidget
 {
+    ~AeroTrimWidget();
     void Setup(std::string const & up, std::string const & dn, std::string const & disp);
     void DisplayFormat(const char* fmt, ...);
     bool UpdateMouseHover() override;
@@ -78,6 +82,8 @@ struct AeroTrimWidget : public AeroInteractiveWidget
     Ogre::OverlayElement *dn_button;
     Ogre::OverlayElement* hovered_button = nullptr;
     Ogre::OverlayElement *display;
+    Ogre::MaterialPtr up_material;
+    Ogre::MaterialPtr down_material;
 };
 
 struct AeroDashOverlay