Skip to content

Commit d2042f8

Browse files
committed
chore: support Noir 1 beta.1
1 parent 2e73cce commit d2042f8

File tree

4 files changed

+4
-6
lines changed

4 files changed

+4
-6
lines changed

.github/workflows/test.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
strategy:
1717
fail-fast: false
1818
matrix:
19-
toolchain: [0.39.0, 1.0.0-beta.0]
19+
toolchain: [0.39.0, 1.0.0-beta.0, 1.0.0-beta.1]
2020
steps:
2121
- name: Checkout sources
2222
uses: actions/checkout@v4
@@ -38,7 +38,7 @@ jobs:
3838
- name: Install Nargo
3939
uses: noir-lang/noirup@v0.1.3
4040
with:
41-
toolchain: 1.0.0-beta.0
41+
toolchain: 1.0.0-beta.1
4242

4343
- name: Run formatter
4444
run: nargo fmt --check

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Nodash is a utility library for [Noir](https://github.com/noir-lang/noir) langua
77
Put this into your Nargo.toml.
88

99
```toml
10-
nodash = { git = "https://github.com/olehmisar/nodash/", tag = "v0.39.3" }
10+
nodash = { git = "https://github.com/olehmisar/nodash/", tag = "v0.39.4" }
1111
```
1212

1313
## Docs

src/math/numeric.nr

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
// TODO: remove this trait if it is implemented in Noir std lib.
21
pub(crate) trait Numeric {
32
fn zero() -> Self;
43
fn one() -> Self;

src/math/sqrt.nr

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
use crate::math::numeric::Numeric;
22
use std::{cmp::Ord, ops::{Add, Div, Mul}};
33

4-
// TODO: check if this is correct
54
pub fn sqrt<T>(value: T) -> T
65
where
76
T: Numeric + Mul + Ord + Add + Div,
87
{
98
let r = unsafe {
10-
// Safety: unsafe sqrt is checked to be between bounds
9+
//@safety: unsafe sqrt is checked to be between bounds
1110
let r = sqrt_unconstrained(value);
1211
assert(value >= r * r);
1312
let ONE: T = Numeric::one();

0 commit comments

Comments
 (0)