Skip to content

Commit 2209ec8

Browse files
committed
Use default configs for testbed receivers
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
1 parent 2fa73ea commit 2209ec8

File tree

1 file changed

+38
-35
lines changed

1 file changed

+38
-35
lines changed

testbed/testbed/receivers.go

+38-35
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import (
2323

2424
"go.opentelemetry.io/collector/component"
2525
"go.opentelemetry.io/collector/config/configmodels"
26+
"go.opentelemetry.io/collector/config/configprotocol"
2627
"go.opentelemetry.io/collector/receiver/jaegerreceiver"
2728
"go.opentelemetry.io/collector/receiver/opencensusreceiver"
2829
"go.opentelemetry.io/collector/receiver/otlpreceiver"
@@ -36,7 +37,7 @@ import (
3637
// an exporter.
3738
type DataReceiver interface {
3839
Start(tc *MockTraceConsumer, mc *MockMetricConsumer) error
39-
Stop()
40+
Stop() error
4041

4142
// Generate a config string to place in exporter part of collector config
4243
// so that it can send data to this receiver.
@@ -59,7 +60,7 @@ func (mb *DataReceiverBase) ReportFatalError(err error) {
5960
}
6061

6162
// GetFactory of the specified kind. Returns the factory for a component type.
62-
func (mb *DataReceiverBase) GetFactory(kind component.Kind, componentType configmodels.Type) component.Factory {
63+
func (mb *DataReceiverBase) GetFactory(_ component.Kind, _ configmodels.Type) component.Factory {
6364
return nil
6465
}
6566

@@ -75,7 +76,7 @@ func (mb *DataReceiverBase) GetExporters() map[configmodels.DataType]map[configm
7576
// OCDataReceiver implements OpenCensus format receiver.
7677
type OCDataReceiver struct {
7778
DataReceiverBase
78-
receiver *opencensusreceiver.Receiver
79+
receiver component.Receiver
7980
}
8081

8182
// Ensure OCDataReceiver implements DataReceiver.
@@ -89,19 +90,22 @@ func NewOCDataReceiver(port int) *OCDataReceiver {
8990
return &OCDataReceiver{DataReceiverBase: DataReceiverBase{Port: port}}
9091
}
9192

92-
func (or *OCDataReceiver) Start(tc *MockTraceConsumer, mc *MockMetricConsumer) error {
93-
addr := fmt.Sprintf("localhost:%d", or.Port)
93+
func (or *OCDataReceiver) Start(tc *MockTraceConsumer, _ *MockMetricConsumer) error {
94+
factory := opencensusreceiver.Factory{}
95+
cfg := factory.CreateDefaultConfig().(*opencensusreceiver.Config)
96+
cfg.SetName("opencensus")
97+
cfg.Endpoint = fmt.Sprintf("localhost:%d", or.Port)
9498
var err error
95-
or.receiver, err = opencensusreceiver.New("opencensus", "tcp", addr, tc, mc)
99+
or.receiver, err = factory.CreateTraceReceiver(context.Background(), zap.NewNop(), cfg, tc)
96100
if err != nil {
97101
return err
98102
}
99103

100104
return or.receiver.Start(context.Background(), or)
101105
}
102106

103-
func (or *OCDataReceiver) Stop() {
104-
or.receiver.Shutdown(context.Background())
107+
func (or *OCDataReceiver) Stop() error {
108+
return or.receiver.Shutdown(context.Background())
105109
}
106110

107111
func (or *OCDataReceiver) GenConfigYAMLStr() string {
@@ -128,26 +132,25 @@ func NewJaegerDataReceiver(port int) *JaegerDataReceiver {
128132
return &JaegerDataReceiver{DataReceiverBase: DataReceiverBase{Port: port}}
129133
}
130134

131-
func (jr *JaegerDataReceiver) Start(tc *MockTraceConsumer, mc *MockMetricConsumer) error {
132-
jaegerCfg := jaegerreceiver.Configuration{
133-
CollectorGRPCPort: jr.Port,
135+
func (jr *JaegerDataReceiver) Start(tc *MockTraceConsumer, _ *MockMetricConsumer) error {
136+
factory := jaegerreceiver.Factory{}
137+
cfg := factory.CreateDefaultConfig().(*jaegerreceiver.Config)
138+
cfg.SetName("jaeger")
139+
cfg.Protocols["grpc"] = &configprotocol.ProtocolServerSettings{
140+
Endpoint: fmt.Sprintf("localhost:%d", jr.Port),
134141
}
135142
var err error
136143
params := component.ReceiverCreateParams{Logger: zap.NewNop()}
137-
jr.receiver, err = jaegerreceiver.New("jaeger", &jaegerCfg, tc, params)
144+
jr.receiver, err = factory.CreateTraceReceiver(context.Background(), params, cfg, tc)
138145
if err != nil {
139146
return err
140147
}
141148

142149
return jr.receiver.Start(context.Background(), jr)
143150
}
144151

145-
func (jr *JaegerDataReceiver) Stop() {
146-
if jr.receiver != nil {
147-
if err := jr.receiver.Shutdown(context.Background()); err != nil {
148-
log.Printf("Cannot stop Jaeger receiver: %s", err.Error())
149-
}
150-
}
152+
func (jr *JaegerDataReceiver) Stop() error {
153+
return jr.receiver.Shutdown(context.Background())
151154
}
152155

153156
func (jr *JaegerDataReceiver) GenConfigYAMLStr() string {
@@ -165,7 +168,7 @@ func (jr *JaegerDataReceiver) ProtocolName() string {
165168
// OTLPDataReceiver implements OTLP format receiver.
166169
type OTLPDataReceiver struct {
167170
DataReceiverBase
168-
receiver *otlpreceiver.Receiver
171+
receiver component.Receiver
169172
}
170173

171174
// Ensure OTLPDataReceiver implements DataReceiver.
@@ -179,19 +182,23 @@ func NewOTLPDataReceiver(port int) *OTLPDataReceiver {
179182
return &OTLPDataReceiver{DataReceiverBase: DataReceiverBase{Port: port}}
180183
}
181184

182-
func (or *OTLPDataReceiver) Start(tc *MockTraceConsumer, mc *MockMetricConsumer) error {
183-
addr := fmt.Sprintf("localhost:%d", or.Port)
185+
func (or *OTLPDataReceiver) Start(tc *MockTraceConsumer, _ *MockMetricConsumer) error {
186+
factory := otlpreceiver.Factory{}
187+
cfg := factory.CreateDefaultConfig().(*otlpreceiver.Config)
188+
cfg.SetName("otlp")
189+
cfg.Endpoint = fmt.Sprintf("localhost:%d", or.Port)
184190
var err error
185-
or.receiver, err = otlpreceiver.New("otlp", "tcp", addr, tc, mc)
191+
params := component.ReceiverCreateParams{Logger: zap.NewNop()}
192+
or.receiver, err = factory.CreateTraceReceiver(context.Background(), params, cfg, tc)
186193
if err != nil {
187194
return err
188195
}
189196

190197
return or.receiver.Start(context.Background(), or)
191198
}
192199

193-
func (or *OTLPDataReceiver) Stop() {
194-
or.receiver.Shutdown(context.Background())
200+
func (or *OTLPDataReceiver) Stop() error {
201+
return or.receiver.Shutdown(context.Background())
195202
}
196203

197204
func (or *OTLPDataReceiver) GenConfigYAMLStr() string {
@@ -209,7 +216,7 @@ func (or *OTLPDataReceiver) ProtocolName() string {
209216
// ZipkinDataReceiver implements Zipkin format receiver.
210217
type ZipkinDataReceiver struct {
211218
DataReceiverBase
212-
receiver *zipkinreceiver.ZipkinReceiver
219+
receiver component.TraceReceiver
213220
}
214221

215222
const DefaultZipkinAddressPort = 9411
@@ -218,13 +225,13 @@ func NewZipkinDataReceiver(port int) *ZipkinDataReceiver {
218225
return &ZipkinDataReceiver{DataReceiverBase: DataReceiverBase{Port: port}}
219226
}
220227

221-
func (zr *ZipkinDataReceiver) Start(tc *MockTraceConsumer, mc *MockMetricConsumer) error {
222-
var err error
228+
func (zr *ZipkinDataReceiver) Start(tc *MockTraceConsumer, _ *MockMetricConsumer) error {
223229
factory := zipkinreceiver.Factory{}
224230
cfg := factory.CreateDefaultConfig().(*zipkinreceiver.Config)
225-
cfg.NameVal = "zipkin"
231+
cfg.SetName("zipkin")
226232
cfg.Endpoint = fmt.Sprintf("localhost:%d", zr.Port)
227-
zr.receiver, err = zipkinreceiver.New(cfg, tc)
233+
var err error
234+
zr.receiver, err = factory.CreateTraceReceiver(context.Background(), zap.NewNop(), cfg, tc)
228235

229236
if err != nil {
230237
return err
@@ -233,12 +240,8 @@ func (zr *ZipkinDataReceiver) Start(tc *MockTraceConsumer, mc *MockMetricConsume
233240
return zr.receiver.Start(context.Background(), zr)
234241
}
235242

236-
func (zr *ZipkinDataReceiver) Stop() {
237-
if zr.receiver != nil {
238-
if err := zr.receiver.Shutdown(context.Background()); err != nil {
239-
log.Printf("Cannot stop Zipkin receiver: %s", err.Error())
240-
}
241-
}
243+
func (zr *ZipkinDataReceiver) Stop() error {
244+
return zr.receiver.Shutdown(context.Background())
242245
}
243246

244247
func (zr *ZipkinDataReceiver) GenConfigYAMLStr() string {

0 commit comments

Comments
 (0)