Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename file_format to avoid confusion #74

Closed
marcalff opened this issue Feb 21, 2024 · 1 comment
Closed

Rename file_format to avoid confusion #74

marcalff opened this issue Feb 21, 2024 · 1 comment

Comments

@marcalff
Copy link
Member

The "YAML file_format", as in this node in config.yaml:

# The file format version
file_format: "0.1"

collides with the "YAML file format" from the spec.

This introduces unnecessary confusion.

Suggested change, rename to configuration_version.

@marcalff
Copy link
Member Author

Just found out other opentelemetry yaml files uses the file_format node, for example in build tools:

https://github.com/open-telemetry/build-tools/blob/main/schemas/testdata/1.13.0-example

Better to keep the same pattern everywhere then.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant